From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D6E5EA4E06 for ; Mon, 2 Mar 2026 13:52:20 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9FF783D79FE for ; Mon, 2 Mar 2026 14:52:19 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 53F283D0666 for ; Mon, 2 Mar 2026 14:52:00 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id C44B46002C8 for ; Mon, 2 Mar 2026 14:51:59 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2D2195BD51; Mon, 2 Mar 2026 13:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772459519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/B06OdvM/gQ5IRLRNkgcHKRJzOnix4BFCHdJF+4STs=; b=R/vz5ia39RkAdZhnpbWuWZxHk9IUM+ZmH3AE2uW8EgG0ENR7sjyJ+f3DY6rK7GamNsNA5O zy9MBU585kNFk5TGunQ1C8x6Dignewzp3xqVWgVtUswRr3AyJ6r5ohFX88kyUkmDxXwrkg k0N/8Qe64TCuIynHgMproCPi+GIu3wM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772459519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/B06OdvM/gQ5IRLRNkgcHKRJzOnix4BFCHdJF+4STs=; b=y02TIbpRrHCBCvjAlPpuiqiMXlg/RakeEtv5cU/u3pg9mSUidMwiKHWm6y84+PcPKC+I+Z 6auPII9LQPXmbiDA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="R/vz5ia3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y02TIbpR DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772459519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/B06OdvM/gQ5IRLRNkgcHKRJzOnix4BFCHdJF+4STs=; b=R/vz5ia39RkAdZhnpbWuWZxHk9IUM+ZmH3AE2uW8EgG0ENR7sjyJ+f3DY6rK7GamNsNA5O zy9MBU585kNFk5TGunQ1C8x6Dignewzp3xqVWgVtUswRr3AyJ6r5ohFX88kyUkmDxXwrkg k0N/8Qe64TCuIynHgMproCPi+GIu3wM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772459519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/B06OdvM/gQ5IRLRNkgcHKRJzOnix4BFCHdJF+4STs=; b=y02TIbpRrHCBCvjAlPpuiqiMXlg/RakeEtv5cU/u3pg9mSUidMwiKHWm6y84+PcPKC+I+Z 6auPII9LQPXmbiDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1A50A3EA69; Mon, 2 Mar 2026 13:51:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Rzl/BP+VpWlKEwAAD6G6ig (envelope-from ); Mon, 02 Mar 2026 13:51:59 +0000 Date: Mon, 2 Mar 2026 14:52:08 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20260123-stream_refactoring-v1-0-281b85f6ab02@suse.com> <20260123-stream_refactoring-v1-6-281b85f6ab02@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260123-stream_refactoring-v1-6-281b85f6ab02@suse.com> X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 2D2195BD51 X-Virus-Scanned: clamav-milter 1.0.9 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 6/6] fs: rewrite stream05 test using new API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Test Project Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > - * > - * Copyright (c) International Business Machines Corp., 2002 Shouldn't this copyright stay? > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > - * the GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + * Copyright (c) 2026 Andrea Cervesato > */ > ... > + stream = SAFE_FOPEN(FILENAME, "a+"); > + SAFE_FWRITE(data, 1, DATASIZE, stream); Shouldn't this be SAFE_FFLUSH(stream) here? The previous test closed and opened the stream before, which explicitly flushed the buffers. > - local_flag = PASSED; > - /*--------------------------------------------------------------------*/ > - //block2: > + fd = TST_EXP_FD(SAFE_FILENO(stream)); This is wrong, either we use SAFE_MACRO or TST_EXP macro. Using both of them like this does not make any sense since the SAFE_FILENO() does not return on a failure. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp