From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57F8BF33A71 for ; Thu, 5 Mar 2026 14:25:57 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 31A0B3DAEF9 for ; Thu, 5 Mar 2026 15:25:55 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1C5183C2EA3 for ; Thu, 5 Mar 2026 15:25:35 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 7A2AF14001F4 for ; Thu, 5 Mar 2026 15:25:34 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 65FC83F9D0; Thu, 5 Mar 2026 14:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772720734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8c/x4ZODDF8JWAgrS/fK2pqid6y8dDAiDUweBmjrPFw=; b=nl8NcjM88o9Ps6FEVYHycdXYTjQ69Po5yjg1iNKKsQC+BW1iO7bv1QfPK6miZ7n56dD/Kd sfc4hMyoZ3k/NccsQsAjbnTJarfOoxk2wB72VKrOhEY7d2U/CI+rlQyh4xw8Hf5GVH5iIM +ewVke8zdafzsaqNxU0Bt1A/aX9P5X8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772720734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8c/x4ZODDF8JWAgrS/fK2pqid6y8dDAiDUweBmjrPFw=; b=xpBnyKYNOEHSO9bWNzjJYTHxxq2C0emkOQ3qwBBEU030B+KfHNU3alWZ66I++kWMoa0GOn kUuEsLNDPMsf/YCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nl8NcjM8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xpBnyKYN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772720734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8c/x4ZODDF8JWAgrS/fK2pqid6y8dDAiDUweBmjrPFw=; b=nl8NcjM88o9Ps6FEVYHycdXYTjQ69Po5yjg1iNKKsQC+BW1iO7bv1QfPK6miZ7n56dD/Kd sfc4hMyoZ3k/NccsQsAjbnTJarfOoxk2wB72VKrOhEY7d2U/CI+rlQyh4xw8Hf5GVH5iIM +ewVke8zdafzsaqNxU0Bt1A/aX9P5X8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772720734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8c/x4ZODDF8JWAgrS/fK2pqid6y8dDAiDUweBmjrPFw=; b=xpBnyKYNOEHSO9bWNzjJYTHxxq2C0emkOQ3qwBBEU030B+KfHNU3alWZ66I++kWMoa0GOn kUuEsLNDPMsf/YCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 56D7E3EA68; Thu, 5 Mar 2026 14:25:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FKSjFF6SqWl0cQAAD6G6ig (envelope-from ); Thu, 05 Mar 2026 14:25:34 +0000 Date: Thu, 5 Mar 2026 15:25:44 +0100 From: Cyril Hrubis To: Li Wang Message-ID: References: <20260304161425.12461-1-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Queue-Id: 65FC83F9D0 X-Virus-Scanned: clamav-milter 1.0.9 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] syscalls: newuname01: Convert to the new library. X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi!1 > > + SAFE_FILE_SCANF("/proc/sys/kernel/hostname", "%1023[^\n]", proc_val); > > + TST_EXP_EQ_STR(name->nodename, proc_val); > > > > - tst_parse_opts(ac, av, NULL, NULL); > > + SAFE_FILE_SCANF("/proc/sys/kernel/osrelease", "%1023[^\n]", proc_val); > > + TST_EXP_EQ_STR(name->release, proc_val); > > > > - setup(); > > + SAFE_FILE_SCANF("/proc/sys/kernel/version", "%1023[^\n]", proc_val); > > + TST_EXP_EQ_STR(name->version, proc_val); > > We'd better clear proc_val between reads: > > proc_val[0] = '\0'; I'm looking at safe_file_scanf() code and it calls tst_brkm_() in any case that no conversion was done. So the buffer should be either be filled with new data or the test should exit with an error. Do I miss something? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp