From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 5/5] syscalls: add listns02 functionality test
Date: Fri, 20 Mar 2026 12:19:42 +0100 [thread overview]
Message-ID: <ab0tTjN_bw8FL-Ay@yuki.lan> (raw)
In-Reply-To: <20260313-listns-v2-5-38384fae9b1f@suse.com>
Hi!
> + if (TST_RET < 0) {
> + tst_res(TFAIL | TTERRNO, "listns() failed for %s", tc->desc);
> + return;
> + }
> +
> + found = 0;
> + for (int i = 0; i < TST_RET; i++) {
> + tst_res(TDEBUG, "buf[%d] = %lu", i, buf[i]);
^
I would say that this is a bit
cryptic.
If we want have debugging output I would add something as:
tst_res(TDEBUG, "Looking for nsid=%lu", ns_id);
for (int i ...) {
tst_res(TDEBUG, "list %i. nsid=%lu", i, buf[i]);
}
Otherwise it looks good:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-03-20 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 11:48 [LTP] [PATCH v2 0/5] listns() testing suite Andrea Cervesato
2026-03-13 11:48 ` [LTP] [PATCH v2 1/5] Update architectures syscalls identifiers Andrea Cervesato
2026-03-20 10:28 ` Cyril Hrubis
2026-03-20 13:21 ` Andrea Cervesato via ltp
2026-03-13 11:48 ` [LTP] [PATCH v2 2/5] Add listns fallback header Andrea Cervesato
2026-03-20 10:35 ` Cyril Hrubis
2026-03-20 13:34 ` Andrea Cervesato via ltp
2026-03-23 10:16 ` Cyril Hrubis
2026-03-24 14:49 ` Andrea Cervesato via ltp
2026-03-13 11:48 ` [LTP] [PATCH v2 3/5] Add NS_GET_ID fallback Andrea Cervesato
2026-03-20 10:36 ` Cyril Hrubis
2026-03-13 11:48 ` [LTP] [PATCH v2 4/5] syscalls: add listns01 test for EFAULT on invalid address Andrea Cervesato
2026-03-20 10:39 ` Cyril Hrubis
2026-03-13 11:48 ` [LTP] [PATCH v2 5/5] syscalls: add listns02 functionality test Andrea Cervesato
2026-03-20 11:19 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0tTjN_bw8FL-Ay@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox