[LTP] [PATCH 1/1] Remove s390x test

[LTP] [PATCH 1/1] Remove s390x test

[Petr Vorel]

vmcp_m.sh is a pure user space test (out of LTP scope). While test
claims testing vmcp tool and module IMHO it's mainly testing vmcp basic
usage (-h, -v), exit codes on error. The only real use is 'vmcp q dasd'.

s390-tools maintainers confirmed they have internal CI and are working
on to be part of s390-tools on GitHub [1]. Another reason to remove.

Remove also runtest/s390x_tests, which contained only this test.

[1] https://github.com/ibm-s390-linux/s390-tools/issues/201

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/s390x_tests               |  2 --
 testcases/commands/vmcp/Makefile  | 10 -------
 testcases/commands/vmcp/vmcp_m.sh | 48 -------------------------------
 3 files changed, 60 deletions(-)
 delete mode 100644 runtest/s390x_tests
 delete mode 100644 testcases/commands/vmcp/Makefile
 delete mode 100644 testcases/commands/vmcp/vmcp_m.sh

diff --git a/runtest/s390x_tests b/runtest/s390x_tests
deleted file mode 100644
index 0c2bf05a5b..0000000000
--- a/runtest/s390x_tests
+++ /dev/null
@@ -1,2 +0,0 @@
-# Those tests are designed to be executed in s390x environment (zVM or LPAR)
-vmcp vmcp_m.sh
diff --git a/testcases/commands/vmcp/Makefile b/testcases/commands/vmcp/Makefile
deleted file mode 100644
index 544b044407..0000000000
--- a/testcases/commands/vmcp/Makefile
+++ /dev/null
@@ -1,10 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
-# Copyright (c) Linux Test Project, 2026
-
-top_srcdir		?= ../../..
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-INSTALL_TARGETS		:= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/commands/vmcp/vmcp_m.sh b/testcases/commands/vmcp/vmcp_m.sh
deleted file mode 100644
index 3924a6e112..0000000000
--- a/testcases/commands/vmcp/vmcp_m.sh
+++ /dev/null
@@ -1,48 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0-or-later
-#
-# vmcp tool and module test
-#
-# The tool allows Linux users to send commands to the z/VM control program (CP).
-# The normal usage is to invoke vmcp with the command you want to execute.
-#
-# The test case contains one shell script:
-#
-# basically executes the vmcp tool with different parameters and verifies that
-# output and exitcodes are as expected
-
-TST_CNT=2
-TST_TESTFUNC=vmcp_main
-TST_NEEDS_CMDS="vmcp"
-
-vmcp_run()
-{
-
-        $2
-        if [ $? -eq $1 ]; then
-            tst_res TPASS "'$2' returned '$1'"
-        else
-            tst_res TFAIL "'$2' did not return '$1'"
-        fi
-}
-
-vmcp_main1()
-{
-        tst_res TINFO "Verify basic VMCP commands"
-        vmcp_run 0 "vmcp --version";
-        vmcp_run 0 "vmcp --help";
-        vmcp_run 0 "vmcp -v";
-        vmcp_run 0 "vmcp -h";
-        vmcp_run 0 "vmcp q dasd";
-}
-
-vmcp_main2()
-{
-        tst_res TINFO "Verify error conditions"
-        vmcp_run 4 "vmcp -L"
-        vmcp_run 4 "vmcp -m q dasd"
-        vmcp_run 1 "vmcp dasddasddasd"
-}
-
-. tst_test.sh
-tst_run
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] Remove s390x test

[Li Wang via ltp]

On Thu, Apr 02, 2026 at 10:04:31PM +0200, Petr Vorel wrote:
> vmcp_m.sh is a pure user space test (out of LTP scope). While test
> claims testing vmcp tool and module IMHO it's mainly testing vmcp basic
> usage (-h, -v), exit codes on error. The only real use is 'vmcp q dasd'.
> 
> s390-tools maintainers confirmed they have internal CI and are working
> on to be part of s390-tools on GitHub [1]. Another reason to remove.
> 
> Remove also runtest/s390x_tests, which contained only this test.

Agreed.
Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp