From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 695ABFEEF25 for ; Tue, 7 Apr 2026 11:24:47 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1A2543E29B1 for ; Tue, 7 Apr 2026 13:24:46 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C17043C9314 for ; Tue, 7 Apr 2026 13:24:26 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 3F1671000371 for ; Tue, 7 Apr 2026 13:24:26 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90EA95BD95; Tue, 7 Apr 2026 11:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1775561064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=; b=iEJfG+wi06wx1mrQaY4QHtd/S3kxsRC6JKwyEicC4G1qNhLGAunlH3JowbzB1lH8wB5F0Z m+8wwKJ+4ylboD84vohxDOsjTmlCo6K/X/+CcLsGCtIBnm/gIPVgk371zUlwWfsPyOJOdA r8rwM0ZFwK4K8X4IRcPfPc3mXGg9Bi4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1775561064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=; b=fRmP12ZjkKV2xKaMD2oNxZKzSrVhRsrIjSbm922Ih66Sec3sCFNLj1X3djB1AygL+2aoqM S2vfHw1nN3lu6cDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1775561063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=; b=ryDVMRLFd0dW2Xo17f6TxFSWmL4AhA0eoKsOPpjHLJ7hsOmV8i1dyY8KRrE923dEvYasYb Hu8fs0set3p1ZpkQoOhgBq+/vBcex4IkzXHHK1PLIxPIlY/EPNP1jZeRZxXH/+P8FHidf5 i+Tz56+Ez+1uYYk5/75kL0ZsgMeTy/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1775561063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TKv1u1gyMqPDfRJ9GVBd3NWJZ/fpJZgZnCLjAHAYKQ=; b=BRYLQBIIcQMzP8Kq4SAHlArmDuFqyMiEqnxxE9Osd35grfKQ9V3bRhSwRrGh4O4pVlJBdN kOW6p5liyVh899Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 828724A0B0; Tue, 7 Apr 2026 11:24:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A1nyHmfp1Gm2UQAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 11:24:23 +0000 Date: Tue, 7 Apr 2026 13:24:29 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20260402121356.31266-1-chrubis@suse.cz> <20260402121356.31266-4-chrubis@suse.cz> <20260402214727.GE225068@pevik> <20260407111501.GA25645@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260407111501.GA25645@pevik> X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[yuki.lan:mid, imap1.dmz-prg2.suse.org:helo, suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.9 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add tst_check_module_driver() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > > Thinking about it twice, could we check for the module by reading > > > /sys/module/? Our current approach shows what module *should* be available, but > > > that might not be true for some reason (i.e. loadable module not installed). > > > The modules.dep file contains names of all modules installed in > > particular kernel modules directory. We cannot do anything better than > > parsing that file because it's (re)genrated on the system each time > > packages with modules have been installed/removed. If that wasn't the > > case modprobe that depends on that file wouldn't work either. > > We effectively ask users to install modules.dep and modules.builtin. While this > is ok for distros and nobody has complained, I can imagine special embedded > systems can have problem. If everything was reliably detectable via /sys or > /proc I'd move to it. But even it's not working for all modules, checking first > /sys/module/ and fallback using modules.{builtin,dep} wouldn't take much effort. My code does not add any new dependencies. The check for module.dep has been in LTP since: 8f7013ba6917 ('tst_check_driver(): Fix kernel module detection on BusyBox') which was introduced five years ago. The only thing that changes is that the check is being moved from needs_drivers to needs_kconfigs. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp