Re: [LTP] [PATCH 16/17] lib: tst_test: Remove now unused needs_drivers

[Li Wang via ltp <ltp@lists.linux.it>]

Overall it's good, just minor polishing below:

> --- a/include/tst_test.h
> +++ b/include/tst_test.h
> @@ -511,6 +511,13 @@ struct tst_fs {
>   *                  and parenthesis are supported, e.g.
>   *                  "CONFIG_X86_INTEL_UMIP=y | CONFIG_X86_UIMP=y" is evaluated
>   *                  to true if at least one of the options is present.

> + *                  For some config options their presence in the config file
> + *                  is not enough to assure the functionality is present or

  Merely finding a config option in the config file does not
  guarantee that the corresponding functionality is available.

> + *                  enabled. E.g. config option may be set to 'm' but the
> + *                  module may not be installed or functionality may be
> + *                  disabled on the kernel command line. The kconfig library

  For instance, an option might be set to 'm' without the
  module being installed, or the feature could be disabled via
  the kernel command line.

> + *                  has a set of additonal checks for a few config options that
> + *                  are used in the tests and need additional checks.

  To address this, the kconfig library implements supplementary
  runtime checks for specific options required by the tests.

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp