* [LTP] [PATCH v2] growfiles:fix test failure due to missing directory
@ 2026-04-09 8:59 lepillai
0 siblings, 0 replies; 3+ messages in thread
From: lepillai @ 2026-04-09 8:59 UTC (permalink / raw)
To: ltp
From: lekshmi-cpillai <lepillai@linux.ibm.com>
Signed-off-by: lekshmi-cpillai <lepillai@linux.ibm.com>
---
testcases/kernel/fs/doio/growfiles.c | 35 +++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/fs/doio/growfiles.c b/testcases/kernel/fs/doio/growfiles.c
index 21960f82a..5a76ef4c5 100644
--- a/testcases/kernel/fs/doio/growfiles.c
+++ b/testcases/kernel/fs/doio/growfiles.c
@@ -119,6 +119,38 @@ int lkfile(int fd, int operation, int lklevel);
int pre_alloc(int fd, long size);
#endif /* !linux */
+/* Helper function to create directories recursively */
+static int mkdir_recursive(const char *path, mode_t mode)
+{
+ char tmp[PATH_MAX];
+ char *p = NULL;
+ size_t len;
+ struct stat st;
+
+ snprintf(tmp, sizeof(tmp), "%s", path);
+ len = strlen(tmp);
+ if (tmp[len - 1] == '/')
+ tmp[len - 1] = 0;
+
+ for (p = tmp + 1; *p; p++) {
+ if (*p == '/') {
+ *p = 0;
+ if (stat(tmp, &st) == -1) {
+ if (mkdir(tmp, mode) == -1 && errno != EEXIST) {
+ return -1;
+ }
+ }
+ *p = '/';
+ }
+ }
+ if (stat(tmp, &st) == -1) {
+ if (mkdir(tmp, mode) == -1 && errno != EEXIST) {
+ return -1;
+ }
+ }
+ return 0;
+}
+
extern int datapidgen(int, char *, int, int);
extern int datapidchk(int, char *, int, int, char **);
@@ -482,7 +514,7 @@ int main(int argc, char **argv)
unsetenv("TMPDIR"); /* force the use of auto_dir */
#endif
if (stat(auto_dir, &statbuf) == -1) {
- if (mkdir(auto_dir, 0777) == -1) {
+ if (mkdir_recursive(auto_dir, 0777) == -1) {
if (errno != EEXIST) {
fprintf(stderr,
"%s%s: Unable to make dir %s\n",
@@ -3058,3 +3090,4 @@ int pre_alloc(int fd, long size)
return 0;
}
#endif
+
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH v2] growfiles:fix test failure due to missing directory
@ 2026-04-09 9:00 lepillai
2026-04-09 9:27 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: lepillai @ 2026-04-09 9:00 UTC (permalink / raw)
To: ltp
From: lekshmi-cpillai <lepillai@linux.ibm.com>
Signed-off-by: lekshmi-cpillai <lepillai@linux.ibm.com>
---
testcases/kernel/fs/doio/growfiles.c | 35 +++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/fs/doio/growfiles.c b/testcases/kernel/fs/doio/growfiles.c
index 21960f82a..5a76ef4c5 100644
--- a/testcases/kernel/fs/doio/growfiles.c
+++ b/testcases/kernel/fs/doio/growfiles.c
@@ -119,6 +119,38 @@ int lkfile(int fd, int operation, int lklevel);
int pre_alloc(int fd, long size);
#endif /* !linux */
+/* Helper function to create directories recursively */
+static int mkdir_recursive(const char *path, mode_t mode)
+{
+ char tmp[PATH_MAX];
+ char *p = NULL;
+ size_t len;
+ struct stat st;
+
+ snprintf(tmp, sizeof(tmp), "%s", path);
+ len = strlen(tmp);
+ if (tmp[len - 1] == '/')
+ tmp[len - 1] = 0;
+
+ for (p = tmp + 1; *p; p++) {
+ if (*p == '/') {
+ *p = 0;
+ if (stat(tmp, &st) == -1) {
+ if (mkdir(tmp, mode) == -1 && errno != EEXIST) {
+ return -1;
+ }
+ }
+ *p = '/';
+ }
+ }
+ if (stat(tmp, &st) == -1) {
+ if (mkdir(tmp, mode) == -1 && errno != EEXIST) {
+ return -1;
+ }
+ }
+ return 0;
+}
+
extern int datapidgen(int, char *, int, int);
extern int datapidchk(int, char *, int, int, char **);
@@ -482,7 +514,7 @@ int main(int argc, char **argv)
unsetenv("TMPDIR"); /* force the use of auto_dir */
#endif
if (stat(auto_dir, &statbuf) == -1) {
- if (mkdir(auto_dir, 0777) == -1) {
+ if (mkdir_recursive(auto_dir, 0777) == -1) {
if (errno != EEXIST) {
fprintf(stderr,
"%s%s: Unable to make dir %s\n",
@@ -3058,3 +3090,4 @@ int pre_alloc(int fd, long size)
return 0;
}
#endif
+
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v2] growfiles:fix test failure due to missing directory
2026-04-09 9:00 [LTP] [PATCH v2] growfiles:fix test failure due to missing directory lepillai
@ 2026-04-09 9:27 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2026-04-09 9:27 UTC (permalink / raw)
To: lepillai; +Cc: ltp
Hi!
Again you have send the patch twice, is there something wrong with your
email setup?
> From: lekshmi-cpillai <lepillai@linux.ibm.com>
^
This stil isn't a clear description why these changes are needed.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-09 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09 9:00 [LTP] [PATCH v2] growfiles:fix test failure due to missing directory lepillai
2026-04-09 9:27 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-04-09 8:59 lepillai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox