From: Cyril Hrubis <chrubis@suse.cz>
To: Wake Liu <wakel@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls/file_attr01: Dynamically expect EOPNOTSUPP on tmpfs without xattr
Date: Thu, 16 Apr 2026 15:49:58 +0200 [thread overview]
Message-ID: <aeDpBp_TNCJYCDzG@yuki.lan> (raw)
In-Reply-To: <20260323074814.2930709-1-wakel@google.com>
Hi!
> @@ -115,20 +116,28 @@ static struct tcase {
> static void run(unsigned int i)
> {
> struct tcase *tc = &tcases[i];
> + int exp_errno = tc->exp_errno;
> +
> + if (tc->ufattr == (struct file_attr **)(&null_ptr)) {
> + const char *const kconfig[] = {"CONFIG_TMPFS_XATTR=y", NULL};
> +
> + if (!strcmp(tst_device->fs_type, "tmpfs") && tst_kconfig_check(kconfig))
> + exp_errno = EOPNOTSUPP;
> + }
The call to tst_kconfig_check() should be done once in the test setup()
and we should set a flag based on the outcome. Without that we will
parse the kernel config in each iteration of the run() function (e.g. if
run the test with -i 10).
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-04-16 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 7:57 [LTP] [PATCH] syscalls/file_attr01: Allow EOPNOTSUPP when attributes is NULL Wake Liu via ltp
2026-03-20 8:57 ` Andrea Cervesato via ltp
2026-03-23 7:26 ` Wake Liu via ltp
2026-03-23 7:48 ` [LTP] [PATCH v2] syscalls/file_attr01: Dynamically expect EOPNOTSUPP on tmpfs without xattr Wake Liu via ltp
2026-03-23 9:07 ` Andrea Cervesato via ltp
2026-04-16 13:49 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeDpBp_TNCJYCDzG@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox