Re: [LTP] [PATCH v3 1/2] lib: Add SAFE_SPLICE() macro

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Add new SAFE_SPLIT() in lapi/splice.h.
> 
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  include/lapi/splice.h | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/include/lapi/splice.h b/include/lapi/splice.h
> index 191b22d2d6397d1efad5e2025be5a2c4370724dc..e346e5cca9f44bd8421c6b99f84cd4646269ac1f 100644
> --- a/include/lapi/splice.h
> +++ b/include/lapi/splice.h
> @@ -7,6 +7,13 @@
>  #ifndef LAPI_SPLICE_H__
>  #define LAPI_SPLICE_H__
>  
> +#ifndef _GNU_SOURCE
> +# define _GNU_SOURCE
> +#endif
> +
> +#include <fcntl.h>
> +#include <sys/types.h>
> +
>  #include "config.h"
>  #include "lapi/syscalls.h"
>  
> @@ -19,4 +26,25 @@ static inline ssize_t splice(int fd_in, loff_t *off_in, int fd_out,
>  }
>  #endif
>  
> +static inline ssize_t safe_splice(const char *file, const int lineno,
> +				   int fd_in, loff_t *off_in,
> +				   int fd_out, loff_t *off_out,
> +				   size_t len, unsigned int flags)
> +{
> +	ssize_t ret;
> +
> +	ret = splice(fd_in, off_in, fd_out, off_out, len, flags);
> +
> +	if (ret < 0) {
> +		tst_brk_(file, lineno, TBROK | TERRNO,
> +			"splice(%d, %d, %zu) failed", fd_in, fd_out, len);

Why don't we print the offsets?


Otherwise:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> +	}
> +
> +	return ret;
> +}
> +
> +#define SAFE_SPLICE(fd_in, off_in, fd_out, off_out, len, flags) \
> +	safe_splice(__FILE__, __LINE__, (fd_in), (off_in), (fd_out), \
> +		    (off_out), (len), (flags))
> +
>  #endif /* LAPI_SPLICE_H__ */
> 
> -- 
> 2.51.0
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp