From: Cyril Hrubis <chrubis@suse.cz>
To: Ricardo Branco <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] userfaultfd: Minor fixes
Date: Tue, 5 May 2026 14:02:26 +0200 [thread overview]
Message-ID: <afncUgcF3YQ5BzIw@yuki.lan> (raw)
In-Reply-To: <20260327160157.76906-1-rbranco@suse.de>
Hi!
> -static void *handle_thread(void)
> +static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)
> {
> static struct uffd_msg msg;
> struct uffdio_writeprotect uffdio_writeprotect = {};
> @@ -53,7 +56,7 @@ static void *handle_thread(void)
> SAFE_READ(1, uffd, &msg, sizeof(msg));
>
> if (msg.event != UFFD_EVENT_PAGEFAULT)
> - tst_brk(TFAIL, "Received unexpected UFFD_EVENT %d", msg.event);
> + tst_brk(TFAIL | TERRNO, "Received unexpected UFFD_EVENT %d", msg.event);
Agree with Andrea that the TERRNO here is wrong. The rest is okay.
With the TERRNO removed:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-05-05 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 16:01 [LTP] [PATCH v3] userfaultfd: Minor fixes Ricardo Branco
2026-03-30 7:24 ` Petr Vorel
2026-03-30 10:15 ` Cyril Hrubis
2026-03-30 10:42 ` Petr Vorel
2026-03-30 7:58 ` Andrea Cervesato via ltp
2026-05-05 12:02 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afncUgcF3YQ5BzIw@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rbranco@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox