Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Piotr Kubaj <piotr.kubaj@intel.com>
Cc: daniel.niestepski@intel.com, tomasz.ossowski@intel.com,
	helena.anna.dubel@intel.com, rafael.j.wysocki@intel.com,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v8] cpufreq.c: add new test for cpufreq sysfs interface validation
Date: Wed, 3 Jun 2026 14:27:26 +0200	[thread overview]
Message-ID: <aiAdruX8LbfeF82y@yuki.lan> (raw)
In-Reply-To: <20260507111145.112276-2-piotr.kubaj@intel.com>

Hi!
> +		SAFE_FILE_SCANF(path, "%255s", contents);
> +		tst_res(TDEBUG, "Checking whether %s is \"intel_pstate\"", path);

I slightly prefer single quotes inside double quotes e.g. " ...
'intel_pstate'" since they does not need to be escaped. And maybe the
run() could have been split into functions so that it's not that long.
But both of these are very minor.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-06-03 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 11:11 [LTP] [PATCH v8] cpufreq.c: add new test for cpufreq sysfs interface validation Piotr Kubaj
2026-05-07 11:57 ` [LTP] " linuxtestproject.agent
2026-05-27  7:27 ` [LTP] [PATCH v8] " Kubaj, Piotr
2026-06-03 12:27 ` Cyril Hrubis [this message]
2026-06-11  7:13 ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiAdruX8LbfeF82y@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=daniel.niestepski@intel.com \
    --cc=helena.anna.dubel@intel.com \
    --cc=ltp@lists.linux.it \
    --cc=piotr.kubaj@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tomasz.ossowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox