Re: [LTP] [PATCH v5 1/2] lib: Introduce tst_path_defs.h to consolidate system paths

[Li Wang <li.wang@linux.dev>]

Cyril Hrubis wrote:

> Hi!
> > +/* NETWORK */
> > +#define PATH_NET_IPV4				"/proc/sys/net/ipv4/"
> > +#define PATH_NET_IPV4_ICMP_RATELIMIT		"/proc/sys/net/ipv4/icmp_ratelimit"
> > +#define PATH_NET_IPV4_ICMP_RATEMASK		"/proc/sys/net/ipv4/icmp_ratemask"
> > +#define PATH_NET_IPV4_ICMP_ECHO_IGNORE_ALL	"/proc/sys/net/ipv4/icmp_echo_ignore_all"
> > +#define PATH_NET_IPV4_ICMP_MSGS_BURST		"/proc/sys/net/ipv4/icmp_msgs_burst"
> > +#define PATH_NET_IPV4_TCP_PROBE_INTERVAL	"/proc/sys/net/ipv4/tcp_probe_interval"
> > +#define PATH_NET_IPV4_TCP_KEEPALIVE_TIME	"/proc/sys/net/ipv4/tcp_keepalive_time"
> > +#define PATH_NET_IPV4_TCP_NOTSENT_LOWAT		"/proc/sys/net/ipv4/tcp_notsent_lowat"
> > +#define PATH_NET_IPV4_IP_LOCAL_RESERVED_PORTS	"/proc/sys/net/ipv4/ip_local_reserved_ports"
> 
> Maybe we can drop the NET here as well, the IPV4 is descriptive enough.
> e.g. PATH_IPV4_ICMP_RATELIMIT

Makes sense. I'll update that before merging and wait for a few more ACKs.

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks!

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp