Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] build: run make check on test sources in kernel module directories
Date: Mon, 15 Jun 2026 14:36:34 +0200	[thread overview]
Message-ID: <ai_x0tylGb7f-XHZ@yuki.lan> (raw)
In-Reply-To: <20260610-fix_buildsystem_modules-v1-1-7f24a774d19d@suse.com>

Hi!
> In directories that build a kernel module, module.mk set CHECK_TARGETS
> with ':=' before env_post.mk could populate it via '?=', leaving it empty
> so 'make check' never ran sparse/checkpatch on the test sources. The filter
> also used a '%.ko' pattern that never matched any 'check-<name>' entry.
> 
> Drop the broken assignment from module.mk and instead exclude the kernel
> module sources (MODULE_SOURCES) in env_post.mk once CHECK_TARGETS has been
> populated, so test sources are checked while kernel module code is skipped.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Also I guess that we may want to run vanilla checkpatch for the module
sources, but that would require a bigger changes I suppose.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-06-15 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 13:00 [LTP] [PATCH] build: run make check on test sources in kernel module directories Andrea Cervesato
2026-06-10 13:25 ` [LTP] " linuxtestproject.agent
2026-06-15 12:36 ` Cyril Hrubis [this message]
2026-06-15 12:44   ` [LTP] [PATCH] " Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ai_x0tylGb7f-XHZ@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox