Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] ksm: Fix sysfs path concatenation in ksm_test.h
Date: Mon, 8 Jun 2026 11:18:47 +0200	[thread overview]
Message-ID: <aiaI90UCa6OTP3dN@yuki.lan> (raw)
In-Reply-To: <20260608085931.3981-1-linuxtestproject.agent@gmail.com>

Hi!
> On Mon, 8 Jun 2026 07:44:15 +0000, Wei Gao wrote:
> > ksm: Fix sysfs path concatenation in ksm_test.h
> 
> > Fixes: 40a366b53adc ("lib: Introduce tst_path_defs.h to consolidate system paths")
> 
> This commit hash does not exist in the LTP repository. Could the
> reference be verified and corrected?
> 
> Verdict: Needs revision


@Andrea the bot still misses existing patches:

$ git log 40a366b53adc

commit 40a366b53adc477d950cc73f071b0cd4ebe25f85
Author: Li Wang <li.wang@linux.dev>
Date:   Thu Jun 4 17:41:59 2026 +0800

    lib: Introduce tst_path_defs.h to consolidate system paths

    We have a lot of hardcoded strings and duplicated macros for /proc
    and /sys paths scattered throughout the testcases.

    This patch introduces a new common header, tst_path_defs.h, to centralize
    and standardize these path definitions. By unifying these macros, we
    reduce code duplication, improve maintainability, and ensure consistent
    path usage across the entire LTP codebase.

    Signed-off-by: Li Wang <li.wang@linux.dev>
    Acked-by: Andrea Cervesato <andrea.cervesato@suse.com>
    Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-06-08  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  7:44 [LTP] [PATCH v1] ksm: Fix sysfs path concatenation in ksm_test.h Wei Gao via ltp
2026-06-08  8:59 ` [LTP] " linuxtestproject.agent
2026-06-08  9:18   ` Cyril Hrubis [this message]
2026-06-08  9:20     ` Andrea Cervesato via ltp
2026-06-08 12:08 ` linuxtestproject.agent
2026-06-09  8:24 ` [LTP] [PATCH v1] " Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiaI90UCa6OTP3dN@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox