Re: [LTP] [PATCH v3 1/2] metadata: add tests grouping support

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > I'm looking at the metadata and we will need at least one follow up.
> > 
> > For tests that are under cve/ directory we add a 'cve' group now, but
> > tests that have cve tag but are in a different place we do not do so.
> > 
> > For consistency we should do:
> > 
> > * Filter out cve as we do with kernel in the group by path
> > 
> > * Possibly add cve group based on cve tag (I would call this optional as
> >   it kind of duplicates the cve tag)
> 
> Do you mean to take a look at the tst_test->tags and verify if we
> have a CVE tag? I think this is possible yes.

Not really. We have quite a lot of cve reproducers that do not have a
cve directory in their path. And then we have reproducers that do have
it. The current metadata has cve group only for the reproducers in the
cve directory which is inconsistent. So I proposed to filter out the
"cve" directory the same way we filter out "kernel". And possibly add
"cve" group based on tags, but that kind of duplicates the tag field, so
it may not make sense to add it.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp