From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 06/13] mem/ksm05: Add proper runtime support
Date: Wed, 24 Jun 2026 14:17:53 +0200 [thread overview]
Message-ID: <ajvK8VLm1vdTCCCo@yuki.lan> (raw)
In-Reply-To: <6a3bc7d7.49afda34.2c585d.d686@mx.google.com>
Hi!
> > static void sighandler(int sig)
> > @@ -91,7 +95,8 @@ static void sighandler(int sig)
> > static struct tst_test test = {
> > .needs_root = 1,
> > .forks_child = 1,
> > - .test_all = test_ksm,
> > + .test_all = run,
> > + .min_runtime = 10,
>
> Even if this is technically correct, I'm not 100% sure about it.
> Now if we want to manually test the binary, we have to wait 10
> seconds by default, while before we had to explicitly use -I.
I would say that the defaults should be geared towards testing not
development. If a test needs 10 seconds to trigger the bug, the default
run without any parameters should run for 10 seconds.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-24 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 9:18 [LTP] [PATCH 00/13] runtest generator prototype for runtest/cve Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 01/13] tst_test: Add may_kmemleak flag and annotate tests Cyril Hrubis
2026-06-24 10:38 ` Andrea Cervesato via ltp
2026-06-24 10:41 ` Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 02/13] keyctl01.sh: Rewrite to the new shell library Cyril Hrubis
2026-06-24 9:59 ` Andrea Cervesato via ltp
2026-06-24 10:57 ` [LTP] tst_test: Add may_kmemleak flag and annotate tests linuxtestproject.agent
2026-06-24 11:08 ` Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 03/13] keyctl01.sh: Remove the keyctl subcommand check Cyril Hrubis
2026-06-24 10:38 ` Andrea Cervesato via ltp
2026-06-24 9:18 ` [LTP] [PATCH 04/13] tst_run_shell: Add support for groups in the env JSON Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 06/13] mem/ksm05: Add proper runtime support Cyril Hrubis
2026-06-24 12:04 ` Andrea Cervesato via ltp
2026-06-24 12:17 ` Cyril Hrubis [this message]
2026-06-24 12:20 ` Andrea Cervesato via ltp
2026-06-24 9:18 ` [LTP] [PATCH 07/13] mem/thp01: " Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 08/13] lib: tst_test: Move the iterations to struct tst_test Cyril Hrubis
2026-06-24 12:05 ` Andrea Cervesato via ltp
2026-06-24 9:18 ` [LTP] [PATCH 09/13] syscalls/setsockopt08: Add .iterations = 100 Cyril Hrubis
2026-06-24 9:18 ` [LTP] [PATCH 11/13] build: rules.mk: Fix HOST_MAKE_TARGET rule Cyril Hrubis
2026-06-24 12:05 ` Andrea Cervesato via ltp
2026-06-24 9:18 ` [LTP] [PATCH 12/13] mem: vma03: Rewrite to the new test library Cyril Hrubis
2026-06-24 9:19 ` [LTP] [PATCH 13/13] metadata: Add runtest file generator Cyril Hrubis
2026-06-24 12:14 ` Andrea Cervesato via ltp
2026-06-24 12:25 ` Cyril Hrubis
2026-06-24 13:22 ` Andrea Cervesato via ltp
2026-06-24 13:27 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajvK8VLm1vdTCCCo@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox