From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 2/2] cve-2026-46331: fix intermittent ENOENT failure
Date: Tue, 21 Jul 2026 11:06:54 +0200 [thread overview]
Message-ID: <al82rifACZS3bJCJ@yuki.lan> (raw)
In-Reply-To: <20260720-fix_cve-2026-46331_enoent-v3-2-9f216efdd661@suse.com>
Hi!
> memset(&pedit_sel_buf, 0, sizeof(pedit_sel_buf));
> @@ -253,7 +278,12 @@ static struct tst_test test = {
> .test_all = run,
> .setup = setup,
> .cleanup = cleanup,
> + .needs_root = 1,
> .needs_tmpdir = 1,
> + .needs_cmds = (struct tst_cmd[]) {
> + {.cmd = "modprobe"},
> + {}
> + },
The last thing I wonder about is if this should stay here, since we now
use the tst_modprobe() the library should handle this dependency
instead.
Other than that:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-21 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 14:31 [LTP] [PATCH v3 0/2] Fix cve-2026-46331 producing ENOENT Andrea Cervesato
2026-07-20 14:31 ` [LTP] [PATCH v3 1/2] tst_kconfig: add module mappings for ingress/matchall/pedit Andrea Cervesato
2026-07-20 15:31 ` Cyril Hrubis
2026-07-21 7:23 ` Andrea Cervesato via ltp
2026-07-21 8:49 ` Cyril Hrubis
2026-07-20 15:55 ` [LTP] " linuxtestproject.agent
2026-07-21 8:51 ` [LTP] [PATCH v3 1/2] " Cyril Hrubis
2026-07-20 14:31 ` [LTP] [PATCH v3 2/2] cve-2026-46331: fix intermittent ENOENT failure Andrea Cervesato
2026-07-21 9:06 ` Cyril Hrubis [this message]
2026-07-21 12:52 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al82rifACZS3bJCJ@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox