From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 3/9] syscalls: Add epoll_wait09
Date: Tue, 14 Jul 2026 11:35:53 +0200 [thread overview]
Message-ID: <alYC-UUGNv4-QVa6@yuki.lan> (raw)
In-Reply-To: <20260710064149.GC1138100@pevik>
Hi!
> > +
> > +#include <sys/epoll.h>
> > +
> > +#include "tst_epoll.h"
> > +#include "tst_test.h"
> > +
> > +#define MAX_DEPTH 5
> > +
> > +static int epfds[MAX_DEPTH];
> > +static int fds[2] = {-1, -1};
> > +
> > +static struct tcase {
> > + int depth;
> > +} tcases[] = {
> > + {2},
> > + {3},
> > + {4},
> > + {5},
>
> nit: why not just define depth in the test?
> int depth = n + 2;
>
> And
> - .tcnt = ARRAY_SIZE(tcases),
> + .tcnt = MAX_DEPTH,
Done, however this has to be MAX_DEPTH-1,
since we are starting at depth 2.
> Also, could you run make check to fix formatting complains?
Also done.
And pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-14 9:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 8:53 [LTP] [PATCH v3 0/9] Add more epoll tests Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 1/9] syscalls: Add epoll_create03 Cyril Hrubis
2026-07-09 10:44 ` [LTP] " linuxtestproject.agent
2026-07-09 14:03 ` Cyril Hrubis
2026-07-09 10:51 ` [LTP] [PATCH v3 1/9] " Petr Vorel
2026-07-09 11:17 ` Petr Vorel
2026-07-09 12:54 ` Cyril Hrubis
2026-07-09 13:40 ` Cyril Hrubis
2026-07-09 14:56 ` Petr Vorel
2026-07-14 9:20 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 2/9] syscalls: Add epoll_wait08 Cyril Hrubis
2026-07-10 6:15 ` Petr Vorel
2026-07-14 9:24 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 3/9] syscalls: Add epoll_wait09 Cyril Hrubis
2026-07-10 6:41 ` Petr Vorel
2026-07-14 9:35 ` Cyril Hrubis [this message]
2026-07-09 8:53 ` [LTP] [PATCH v3 4/9] syscalls: Add epoll_ctl06 Cyril Hrubis
2026-07-10 6:25 ` Petr Vorel
2026-07-14 9:44 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 5/9] syscalls: Add epoll_wait10 Cyril Hrubis
2026-07-10 6:55 ` Petr Vorel
2026-07-14 10:11 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 6/9] syscalls: Add epoll_wait11 Cyril Hrubis
2026-07-10 7:01 ` Petr Vorel
2026-07-14 10:16 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 7/9] SAFE_MACROS: Add SAFE_POLL() Cyril Hrubis
2026-07-10 7:05 ` Petr Vorel
2026-07-14 8:07 ` Andrea Cervesato via ltp
2026-07-14 8:33 ` Andrea Cervesato via ltp
2026-07-14 10:34 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 8/9] syscalls: Add epoll_wait12 Cyril Hrubis
2026-07-10 7:27 ` Petr Vorel
2026-07-14 11:47 ` Cyril Hrubis
2026-07-09 8:53 ` [LTP] [PATCH v3 9/9] syscalls: Remove old epoll-ltp test Cyril Hrubis
2026-07-10 7:30 ` Petr Vorel
2026-07-14 11:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alYC-UUGNv4-QVa6@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox