From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAFA6C5B572 for ; Thu, 13 Aug 2026 10:12:16 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 5F1413E6BEA for ; Thu, 13 Aug 2026 12:12:15 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CCA213E28A4 for ; Thu, 13 Aug 2026 12:12:01 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id AD30E600789 for ; Thu, 13 Aug 2026 12:12:00 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B2254C46; Thu, 13 Aug 2026 10:12:00 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 02D1077D77; Thu, 13 Aug 2026 10:11:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jzDzOG+YfWq9SwAAD6G6ig (envelope-from ); Thu, 13 Aug 2026 10:11:59 +0000 Date: Thu, 13 Aug 2026 12:12:02 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <6a7d65ef.3527643f.912f0.f60e@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a7d65ef.3527643f.912f0.f60e@mx.google.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 1B2254C46 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.9 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] refluxfs: Check kernel reflink support before mount X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > > + if (TST_RET == -1 && TST_ERR == EOPNOTSUPP) > > > + tst_brk(TCONF, "Kernel does not support XFS reflinks"); > > > > Wouldn't it make more sense to add the check for EOPNOTSUPP into the > > tst_test.c library? > > I don't know if we really need to add something in the LTP library, > since we have this check only in file_attr02 I mean that we should rather than hacking around it in the tests handle EOPNOTSUPP properly in the test libray when mounting filesystems. We do enough magick in safe_mount() to support FUSE and handle other corner cases, checking for EOPNOTSUPP (possibly with non-standard mount flags) does sound like a reasonable extension. The main point of handling the filesystems in the test library is that cleanup (umounting) is handled properly even if the test crashes. If we move the code back to the tests like this we lose that. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp