Linux Test Project
 help / color / mirror / Atom feed
From: Li Wang <li.wang@linux.dev>
To: Andrea Cervesato <andrea.cervesato@suse.com>, wakel@google.com
Cc: Wake Liu via ltp <ltp@lists.linux.it>, Li Wang <liwang@hygon.cn>
Subject: Re: [LTP] [PATCH v4] lib: Use backoff polling to wait for loop device nodes
Date: Wed, 5 Aug 2026 15:10:50 +0800	[thread overview]
Message-ID: <anLhvtnHhHay5Y93@linux.dev> (raw)
In-Reply-To: <6a72de5d.d5b2c389.26c2a.b4e4@mx.google.com>

Andrea Cervesato via ltp wrote:

> Hi Wake,
> 
> I sent the Reviewed-by tag to the wrong email. @Li the agent review is
> correct and backoff polling is not working with old API. We need to find
> an another way for that.
> 
> As you can see the CI is failing everywhere in v4:
> https://patchwork.kernel.org/project/ltp/patch/20260805025418.1249003-1-wakel@google.com/

Yes, a simple way to fix it is to declare the tst_multiply_timeout()
in tst_common.h directly, then the lib can build successfully.

--- a/include/tst_common.h
+++ b/include/tst_common.h
@@ -26,6 +26,8 @@
 #define LTP_ALIGN(x, a)    __LTP_ALIGN_MASK(x, (typeof(x))(a) - 1)
 #define __LTP_ALIGN_MASK(x, mask)  (((x) + (mask)) & ~(mask))

+unsigned int tst_multiply_timeout(unsigned int timeout);
+
 /**
  * TST_RETRY_FUNC() - Repeatedly retry a function with an increasing delay.
  * @FUNC - The function which will be retried


-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-05  7:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 15:27 [LTP] [PATCH] lib: Use exponential-backoff polling to wait for loop device nodes Wake Liu via ltp
2026-08-03 16:28 ` [LTP] " linuxtestproject.agent
2026-08-04  1:59 ` [LTP] [PATCH v2] lib: Use backoff " Wake Liu via ltp
2026-08-04  3:58   ` Li Wang
2026-08-04 15:24     ` [LTP] [PATCH v3] " Wake Liu via ltp
2026-08-05  2:24       ` Li Wang
2026-08-05  2:54         ` [LTP] [PATCH v4] " Wake Liu via ltp
2026-08-05  4:09           ` [LTP] " linuxtestproject.agent
2026-08-05  6:53             ` Li Wang
2026-08-05  6:35           ` [LTP] [PATCH v4] " Li Wang
2026-08-05  6:52           ` Andrea Cervesato via ltp
2026-08-05  6:55           ` Andrea Cervesato via ltp
2026-08-05  7:10             ` Li Wang [this message]
2026-08-07 10:04               ` [LTP] [PATCH v5] " Wake Liu via ltp
2026-08-07 11:05                 ` [LTP] " linuxtestproject.agent
2026-08-07 23:49                   ` [LTP] [PATCH v6] " Wake Liu via ltp
2026-08-08  1:32                     ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anLhvtnHhHay5Y93@linux.dev \
    --to=li.wang@linux.dev \
    --cc=andrea.cervesato@suse.com \
    --cc=liwang@hygon.cn \
    --cc=ltp@lists.linux.it \
    --cc=wakel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox