Re: [LTP] [PATCH v1 00/31] Add sysfs sanity tests

[Li Wang <li.wang@linux.dev>]

Cyril Hrubis wrote:

> This is a first bach of the sysfs sanity tests I've been working on
> recently.
> 
> The main goal of these tests is to make sure that these files contains
> expected data, e.g. files that are supposes to be boolean are 0 or 1,
> numeric files contain numbers, etc.
> 
> I've tried to make the code of the tests as clear as possible. Hence the
> first addition in this patchset is a library that implements common
> assertions for sysfs files to be done in a single line of a code.
> 
> Majority of these tests are just reading the files and checking that the
> content is sane. The exceptions are loop device, veth, tap tests that
> cerate virtual devices, which attributes can be changed freely.
> 
> v2:
> 
> Fixed all problems pointed out by Li and real problems by the LTP reviewer.

Generally looks good. I did a quick review - didn't dig into the details,
but the test results look solid. :)

Reviewed-by: Li Wang <li.wang@linux.dev>
Tested-by: Li Wang <li.wang@linux.dev>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp