From: Cyril Hrubis <chrubis@suse.cz>
To: "Kubaj, Piotr" <piotr.kubaj@intel.com>
Cc: "Niestepski, Daniel" <daniel.niestepski@intel.com>,
"Ossowski, Tomasz" <tomasz.ossowski@intel.com>,
"Dubel, Helena Anna" <helena.anna.dubel@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3] pmc_core: add test for pkgc_blocker_residency_show
Date: Fri, 28 Aug 2026 14:35:06 +0200 [thread overview]
Message-ID: <apGAei1EG3ioALnL@yuki.lan> (raw)
In-Reply-To: <2ae1b4ad5c5212d346387aa6b61b2e97c9d69b1c.camel@intel.com>
Hi!
> One question: there doesn't seem to be a way to check whether debugfs
> is mounted, apart from implementing it myself. I have another test in
> the queue for LTR counters that also uses debugfs. Does it make sense
> to put that debugfs check somewhere in the framework, or do you prefer
> it to be put directly in the tests? It's about 25 LOC.
If more than one test would use it makes sense to add a library support
for mounting debugfs.
Also generally distributions are moving into not mounting debugfs by
default, since there have been security implications of exporting
internal kernel state by default. So it would make sense to add
.needs_debugfs flag to the tst_test struct that would cause the library
mount (and later umount) debugfs at .mntpoint unconditionally.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-08-28 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 6:40 [LTP] [PATCH v3] pmc_core: add test for pkgc_blocker_residency_show Piotr Kubaj
2026-08-17 6:57 ` [LTP] " linuxtestproject.agent
2026-08-18 8:15 ` [LTP] [PATCH v3] " Kubaj, Piotr
2026-08-28 12:35 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apGAei1EG3ioALnL@yuki.lan \
--to=chrubis@suse.cz \
--cc=daniel.niestepski@intel.com \
--cc=helena.anna.dubel@intel.com \
--cc=ltp@lists.linux.it \
--cc=piotr.kubaj@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tomasz.ossowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox