From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>,
Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] lib: Check minimal supported kernel version
Date: Thu, 10 Sep 2026 16:44:43 +0200 [thread overview]
Message-ID: <aqLCW1fWNGxTX8mo@yuki.lan> (raw)
In-Reply-To: <apqTA2QG3LdEVX5F@linux.dev>
Hi!
> > Define the minimal supported kernel version in tst_kvercmp.h so that
> > the documentation fetches it dynamically and the core library aborts
> > unsupported kernels with TCONF during test setup.
>
> The description doesn't match the code.
> Other than that, it looks good to me.
Indeed. Feel free to add my reviewed by with this description adjusted.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-10 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:34 [LTP] [PATCH v2] lib: Check minimal supported kernel version Andrea Cervesato
2026-09-04 9:44 ` Li Wang
2026-09-10 14:44 ` Cyril Hrubis [this message]
2026-09-04 10:41 ` [LTP] " linuxtestproject.agent
2026-09-04 10:45 ` Andrea Cervesato via ltp
2026-09-11 6:41 ` [LTP] [PATCH v2] " Andrea Cervesato via ltp
2026-09-11 6:44 ` Cyril Hrubis
2026-09-11 10:12 ` Petr Vorel
2026-09-11 7:16 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqLCW1fWNGxTX8mo@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox