Re: [LTP] [PATCH v2 13/33] keyctl21: Negative and boundary tests for KEYCTL_MOVE

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Test error and boundary conditions of KEYCTL_MOVE using a
> parameterized tcase table: KEYCTL_MOVE_EXCL (EEXIST), unknown flag
> bits (EINVAL), bogus IDs (ENOKEY), non-keyrings (ENOTDIR), unlinked
> key (ENOENT), keyring cycle (EDEADLK), and destination without
> Write permission (EACCES).
> 
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  runtest/syscalls                            |   1 +
>  testcases/kernel/syscalls/keyctl/.gitignore |   1 +
>  testcases/kernel/syscalls/keyctl/keyctl21.c | 111 ++++++++++++++++++++++++++++
>  3 files changed, 113 insertions(+)
> 
> diff --git a/runtest/syscalls b/runtest/syscalls
> index bfe4090a0..b95264564 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -738,6 +738,7 @@ keyctl17 keyctl17
>  keyctl18 keyctl18
>  keyctl19 keyctl19
>  keyctl20 keyctl20
> +keyctl21 keyctl21
>  
>  kcmp01 kcmp01
>  kcmp02 kcmp02
> diff --git a/testcases/kernel/syscalls/keyctl/.gitignore b/testcases/kernel/syscalls/keyctl/.gitignore
> index acddfa79e..e8c71e79e 100644
> --- a/testcases/kernel/syscalls/keyctl/.gitignore
> +++ b/testcases/kernel/syscalls/keyctl/.gitignore
> @@ -18,3 +18,4 @@
>  /keyctl18
>  /keyctl19
>  /keyctl20
> +/keyctl21
> diff --git a/testcases/kernel/syscalls/keyctl/keyctl21.c b/testcases/kernel/syscalls/keyctl/keyctl21.c
> new file mode 100644
> index 000000000..a2db5a406
> --- /dev/null
> +++ b/testcases/kernel/syscalls/keyctl/keyctl21.c
> @@ -0,0 +1,111 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2026 Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +/*\
> + * Negative and boundary test cases for ``KEYCTL_MOVE`` of :manpage:`keyctl(2)`.
> + *
> + * [Algorithm]
> + *
> + * - ``KEYCTL_MOVE_EXCL`` fails with ``EEXIST`` when the destination already
> + *   holds a matching key
> + * - unknown flag bits are rejected with ``EINVAL``
> + * - bogus key or keyring ids fail with ``ENOKEY``
> + * - a plain key used as source or destination keyring fails with ``ENOTDIR``
> + * - moving a key that is not linked in the source fails with ``ENOENT``
> + * - moving a keyring into itself fails with ``EDEADLK`` from the keyring
> + *   cycle detection
> + * - moving into a keyring without Write permission fails with ``EACCES``
> + */
> +
> +#include "keyctl_common.h"
> +
> +#define RING_A_DESC	"ltpkeyctl21_a"
> +#define RING_B_DESC	"ltpkeyctl21_b"
> +#define RING_C_DESC	"ltpkeyctl21_c"
> +#define KEY_A_DESC	"ka"
> +#define KEY_B_DESC	"kb"
> +#define PAYLOAD		"payload"
> +
> +static key_serial_t ring_a, ring_b, ring_c, ring_no_write;
> +static key_serial_t key_a, key_b, key_excl;
> +static key_serial_t bogus_id = INT32_MAX;
> +
> +static struct tcase {
> +	key_serial_t *keyid;
> +	key_serial_t *from;
> +	key_serial_t *to;
> +	unsigned int flags;
> +	int exp_errno;
> +	const char *desc;
> +} tcases[] = {
> +	{ &key_a, &ring_a, &ring_b, KEYCTL_MOVE_EXCL,
> +	  EEXIST, "KEYCTL_MOVE_EXCL on existing key" },
> +
> +	{ &key_a, &ring_a, &ring_b, 0x2,
> +	  EINVAL, "unknown flag bits" },
> +
> +	{ &bogus_id, &ring_a, &ring_b, 0,
> +	  ENOKEY, "bogus key id" },
> +
> +	{ &key_a, &bogus_id, &ring_b, 0,
> +	  ENOKEY, "bogus source keyring" },
> +
> +	{ &key_a, &ring_a, &bogus_id, 0,
> +	  ENOKEY, "bogus destination keyring" },
> +
> +	{ &key_a, &key_b, &ring_b, 0,
> +	  ENOTDIR, "plain key as source keyring" },
> +
> +	{ &key_a, &ring_a, &key_b, 0,
> +	  ENOTDIR, "plain key as destination keyring" },
> +
> +	{ &key_b, &ring_a, &ring_b, 0,
> +	  ENOENT, "key not linked in the source keyring" },
> +
> +	{ &ring_c, &ring_b, &ring_c, 0,
> +	  EDEADLK, "keyring into itself" },
> +
> +	{ &key_a, &ring_a, &ring_no_write, 0,
> +	  EACCES, "destination without Write permission" },
> +};
> +
> +static void setup(void)
> +{
> +	SAFE_KEYCTL(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0);
> +
> +	ring_a = new_ring(RING_A_DESC);
> +	ring_b = new_ring(RING_B_DESC);
> +	ring_c = new_ring(RING_C_DESC);
> +	ring_no_write = new_ring("ltpkeyctl21_nowrite");
> +	SAFE_KEYCTL(KEYCTL_SETPERM, ring_no_write, KEY_PERM_NO_WRITE, 0, 0);
> +
> +	key_a = new_user_key(KEY_A_DESC, PAYLOAD, sizeof(PAYLOAD), ring_a);
> +	key_b = new_user_key(KEY_B_DESC, PAYLOAD, sizeof(PAYLOAD), ring_b);
> +	key_excl = new_user_key(KEY_A_DESC, PAYLOAD, sizeof(PAYLOAD), ring_b);

Same here, the new_ring and new_user_key should have been SAFE_..
macros.


Other than that it looks fine.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp