From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] openposix: timer_*/speculative: fork() to isolate the SIGSEGV on old glibc
Date: Wed, 30 Sep 2026 12:12:14 +0200 [thread overview]
Message-ID: <arzgfgwBYk2ivB8a@yuki.lan> (raw)
In-Reply-To: <20260930091021.GB2623399@pevik>
Hi!
> nit: I suggest before merge to mention the version:
>
> "Recent POSIX versions leave" => "/Since POSIX 2016 Edition is"
>
> (no need for v4). Why? In 5+ years we can hopefully delete those tests.
> Specifying the version saves somebody searching it again.
>
> The code itself LGTM.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
Agree, with that minor change:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Also I find this safe enough to be applied before release as this change
touches only a few speculative tests.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-30 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:47 [LTP] [PATCH] openposix: timer_*/speculative: Handle SIGSEGV on old glibc Avinesh Kumar via ltp
2026-09-29 17:50 ` [LTP] " linuxtestproject.agent
2026-09-29 19:31 ` [LTP] [PATCH v2] openposix: timer_*/speculative: fork() to isolate the " Avinesh Kumar via ltp
2026-09-29 22:04 ` [LTP] " linuxtestproject.agent
2026-09-30 7:35 ` Petr Vorel
2026-09-30 8:46 ` [LTP] [PATCH v3] " Avinesh Kumar via ltp
2026-09-30 9:10 ` Petr Vorel
2026-09-30 10:12 ` Cyril Hrubis [this message]
2026-09-30 12:02 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arzgfgwBYk2ivB8a@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox