From: Li Wang <li.wang@linux.dev>
To: ltp@lists.linux.it
Cc: Xiaochen Shen <shenxiaochen@open-hieco.net>
Subject: Re: [LTP] [PATCH v3 1/2] lib: add a checked-attribute counter to sysfs assert helpers
Date: Wed, 21 Oct 2026 11:10:57 +0800 [thread overview]
Message-ID: <atgtQUefWKTfkTz-@linux.dev> (raw)
In-Reply-To: <20261021025911.165250-1-li.wang@linux.dev>
> --- a/lib/tst_sysfs_assert.c
> +++ b/lib/tst_sysfs_assert.c
> @@ -15,6 +15,17 @@
> #include "tst_test.h"
> #include "tst_sysfs_assert.h"
>
> +static unsigned int tst_sysfs_cnt;
> +
> +static int silent_attr_exists(const char *path)
> +{
> + if (access(path, F_OK))
> + return 0;
> +
> + tst_sysfs_cnt++;
> + return 1;
> +}
After sending out the patch, I realized that the silent_attr_exists()
helper isn't really necessary — we can just add tst_sysfs_cnt++ directly
in the silent functions.
So let me resend v4.
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-10-21 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:59 [LTP] [PATCH v3 1/2] lib: add a checked-attribute counter to sysfs assert helpers Li Wang (Hieco)
2026-10-21 2:59 ` [LTP] [PATCH v3 2/2] sys_hwmon01: always report a result Li Wang (Hieco)
2026-10-21 3:10 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atgtQUefWKTfkTz-@linux.dev \
--to=li.wang@linux.dev \
--cc=ltp@lists.linux.it \
--cc=shenxiaochen@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox