From: Cyril Hrubis <chrubis@suse.cz>
To: "Li Wang (Hieco)" <li.wang@linux.dev>
Cc: Xiaochen Shen <shenxiaochen@open-hieco.net>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 2/2] sys_hwmon01: always report a result
Date: Wed, 21 Oct 2026 13:27:55 +0200 [thread overview]
Message-ID: <atihuztAXCPk1kGr@yuki.lan> (raw)
In-Reply-To: <20261021031816.166499-2-li.wang@linux.dev>
Hi!
> v2:
> - rename attr_exists() to sysfs_attr_exists() (Xiaochen)
> - flatten the final result reporting with an early return (Xiaochen)
> - fix a preexisting off-by-one in the inN channel loop (Xiaochen)
It's very minor however unrelated fixes should be ideally done in a
separate patches.
Feel free to push with my Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
with the off-by-one split into separate patch.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-10-21 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 3:18 [LTP] [PATCH v4 1/2] lib: add a checked-attribute counter to sysfs assert helpers Li Wang (Hieco)
2026-10-21 3:18 ` [LTP] [PATCH v4 2/2] sys_hwmon01: always report a result Li Wang (Hieco)
2026-10-21 11:27 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atihuztAXCPk1kGr@yuki.lan \
--to=chrubis@suse.cz \
--cc=li.wang@linux.dev \
--cc=ltp@lists.linux.it \
--cc=shenxiaochen@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox