Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: "Li Wang (Hieco)" <li.wang@linux.dev>
Cc: wakel@google.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v7 1/4] lib: add module is loaded check
Date: Fri, 6 Nov 2026 13:42:16 +0100	[thread overview]
Message-ID: <au3LKGR79fSjxMzq@yuki.lan> (raw)
In-Reply-To: <20261103075722.181317-2-li.wang@linux.dev>

Hi!
> +		if (i == mod_len) {

Shouldn't we check that next character is a whitespace here?

I guess that module name that is prefix of unrelated module is going to
be rare but it's not impossible.

> +			fclose(file);
> +			return true;
> +		}
> +	}
> +
> +	fclose(file);
> +	return false;
> +}

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-11-06 12:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  7:57 [LTP] [PATCH v7 0/4] tst_kconfig: automatic module load/unload for CONFIG_*=m Li Wang (Hieco)
2026-11-03  7:57 ` [LTP] [PATCH v7 1/4] lib: add module is loaded check Li Wang (Hieco)
2026-11-03 10:19   ` [LTP] " linuxtestproject.agent
2026-11-06 12:42   ` Cyril Hrubis [this message]
2026-11-09  3:25     ` [LTP] [PATCH v7 1/4] " Li Wang
2026-11-11 16:13       ` Cyril Hrubis
2026-11-03  7:57 ` [LTP] [PATCH v7 2/4] tst_kconfig: load and unload kernel modules for CONFIG_*=m Li Wang (Hieco)
2026-11-06 12:50   ` Cyril Hrubis
2026-11-09  3:36     ` Li Wang
2026-11-03  7:57 ` [LTP] [PATCH v7 3/4] tst_kconfig: add module mappings for vsock/vsock_loopback Li Wang (Hieco)
2026-11-03  7:57 ` [LTP] [PATCH v7 4/4] testcases: drop manual tst_modprobe() now handled by tst_kconfig Li Wang (Hieco)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au3LKGR79fSjxMzq@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=li.wang@linux.dev \
    --cc=ltp@lists.linux.it \
    --cc=wakel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox