From: Cyril Hrubis <chrubis@suse.cz>
To: Wake Liu <wakel@google.com>
Cc: ltp@lists.linux.it, linuxtestproject.agent@gmail.com
Subject: Re: [LTP] sys_rtc01: Report TCONF on system time mismatch when STA_UNSYNC is set
Date: Thu, 19 Nov 2026 08:55:54 +0100 [thread overview]
Message-ID: <av6rijAJdAToOmET@yuki.lan> (raw)
In-Reply-To: <20261118131808.682117-1-wakel@google.com>
Hi!
> > Hmm, I guess that the logic should be the other way, if STA_UNSYNC is
> > not set the clock was modified by NTP and the test should be skipped:
>
> I think the logic in 3d11e5dd622e as applied is the right way around;
> inverting it would bring back the failure this patch fixes.
I was thinking about this yesterday and I think that we should redesign
the test to make it simpler and more robust. I will send a patch that
changes the test so that it samples rtc and monotonic timer for a while
and checks that they increase in the same steps. That removes the
absolute offset and the test stops being dependend on time being in
sync.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-11-19 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:58 [LTP] [PATCH] sys_rtc01: Report TCONF on system time mismatch when STA_UNSYNC is set Wake Liu via ltp
2026-11-18 4:49 ` [LTP] " linuxtestproject.agent
2026-11-18 10:12 ` Cyril Hrubis
2026-11-18 13:18 ` Wake Liu via ltp
2026-11-19 7:55 ` Cyril Hrubis [this message]
2026-11-18 9:23 ` [LTP] [PATCH] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av6rijAJdAToOmET@yuki.lan \
--to=chrubis@suse.cz \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox