public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Xiao Yang <ice_yangxiao@163.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse
Date: Wed, 10 Mar 2021 22:54:17 +0800	[thread overview]
Message-ID: <b11680c3-7878-b06b-e87a-8991bd3cb305@163.com> (raw)
In-Reply-To: <YEigO2gryF1Kp6Gq@pevik>

On 3/10/21 6:32 PM, Petr Vorel wrote:
> Hi,
>
>> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
>> -static const char *const resource_files[] = {
>> -	TEST_APP,
>> -	NULL,
>> -};
>> -
>>   static struct tst_test test = {
>>   	.test_all = verify_creat,
>>   	.needs_checkpoints = 1,
>>   	.forks_child = 1,
>> -	.resource_files = resource_files,
>> +	.resource_files = (const char *const []) {
>> +		TEST_APP,
> Don't we want to drop TEST_APP definition and use file directly?
> Having TEST_APP does not say much.

Hi Petr,


I can use file name directly in v2 patch.

Do you agree to use anonymous .resource_files for now? or is it better 
to keep it?


> Not sure how far we should go with moving everything into inline anonymous
> definitions (it'd be nice if docparse was able to just expand macros, but that
> would be way too slow).

I agree that expanding macros or structs is the nicer way but

we need to do some investigation about it.


Best Regards,

Xiao Yang

>
> Kind regards,
> Petr
>


  reply	other threads:[~2021-03-10 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  2:32 [LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse Xiao Yang
2021-03-10 10:32 ` Petr Vorel
2021-03-10 14:54   ` Xiao Yang [this message]
2021-03-10 17:21     ` Petr Vorel
2021-03-11 10:33       ` Petr Vorel
2021-03-11 10:42         ` Cyril Hrubis
2021-03-12 11:05           ` Petr Vorel
2021-03-12 13:12             ` Cyril Hrubis
2021-03-12 13:24               ` Petr Vorel
2022-02-25 12:37                 ` Petr Vorel
2022-08-23 14:24                   ` Cyril Hrubis
2022-08-23 15:47                     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b11680c3-7878-b06b-e87a-8991bd3cb305@163.com \
    --to=ice_yangxiao@163.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox