Re: [LTP] [PATCH 0/4 v2] (merged) cpuhotplug fixes

Stanislav Kholmanskikh
2015-04-29T13:11:37Z

On 04/29/2015 02:17 PM, Jan Stancek wrote:
> Hi,
>
> This patchset is result of merge of following series:
> http://article.gmane.org/gmane.linux.ltp/22762
> http://article.gmane.org/gmane.linux.ltp/22678
>
> It is based on patchset from Stanislav, with changes
> noted below:
> 1. cpuhotplug: use cpu states in cleanup
> no changes to Stanislav's version
> 2. cpu_hotplug: added get_hotplug_cpus, get_hotplug_cpus_num
> This patch has been merged with my 'get_present_cpus' patch,
> get_hotplug_cpus has been modified to operate on present cpus
> only.
> 3. cpu_hotplug: use hotplug/present cpus functions
> This comes from my series, there is no counterpart or conflict
> with Stanislav's patchset.
> 4. cpuhotplug04.sh: operate only with hotpluggable CPUs
> minor change here to use number of present CPUs, rather than all
>
> @Stanislav: Can you please review this series and check, whether
> it still fixes issue you met on sparc64 kernel?

Big thanks for this work. I have few comments for patches 2 and 3.

Yes, this series fixes the issue I met on our sparc64 kernel. To be
honest, there is no cpu hotplug (yet), so all this test cases return
TCONF ;)

>
> Regards,
> Jan
>
>
> Jan Stancek (1):
> cpu_hotplug: use hotplug/present cpus functions
>
> Stanislav Kholmanskikh (3):
> cpuhotplug: use cpu states in cleanup
> cpu_hotplug: add get_hotplug_cpus, get_present_cpus
> cpuhotplug04.sh: operate only with hotpluggable CPUs
>
> .../hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 17 ++---
> .../hotplug/cpu_hotplug/functional/cpuhotplug02.sh | 2 +-
> .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 16 ++--
> .../hotplug/cpu_hotplug/functional/cpuhotplug04.sh | 74 +++++++++---------
> .../hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 2 +-
> .../hotplug/cpu_hotplug/functional/cpuhotplug06.sh | 2 +-
> .../hotplug/cpu_hotplug/functional/cpuhotplug07.sh | 2 +-
> .../cpu_hotplug/include/cpuhotplug_hotplug.sh | 89 +++++++++++++++++++---
> 8 files changed, 135 insertions(+), 69 deletions(-)