Re: [LTP] [PATCH 3/4] cpu_hotplug: use hotplug/present cpus functions

Stanislav Kholmanskikh
2015-04-29T15:03:28Z

On 04/29/2015 05:41 PM, Jan Stancek wrote:
>
>
>
>
> ----- Original Message -----
>> From: "Stanislav Kholmanskikh" <stanislav.kholmanskikh@oracle.com>
>> To: "Jan Stancek" <jstancek@redhat.com>, ltp-list@lists.sourceforge.net
>> Sent: Wednesday, 29 April, 2015 3:09:06 PM
>> Subject: Re: [PATCH 3/4] cpu_hotplug: use hotplug/present cpus functions
>>
>> On 04/29/2015 02:18 PM, Jan Stancek wrote:
>>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>>> ---
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 6
>>> +++---
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh | 2 +-
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 4 ++--
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug04.sh | 4 ++--
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 2 +-
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh | 2 +-
>>> testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug07.sh | 2 +-
>>> 7 files changed, 11 insertions(+), 11 deletions(-)
>>>
>>> diff --git
>>> a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> index 52598a9..8ae1379 100755
>>> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh
>>> @@ -111,7 +111,7 @@ LOOP_COUNT=1
>>>
>>> tst_check_cmds perl
>>>
>>> -get_cpus_num
>>> +get_present_cpus_num
>>> if [ $? -lt 2 ]; then
>>> tst_brkm TCONF "system doesn't have required CPU hotplug support"
>>> fi
>>> @@ -148,7 +148,7 @@ do
>>> IRQ_START=$(cat /proc/interrupts)
>>>
>>> # Attempt to offline all CPUs
>>> - for cpu in $( get_all_cpus ); do
>>> + for cpu in $( get_hotplug_cpus ); do
>>> if [ "$cpu" = "cpu0" ]; then
>>> continue
>>> fi
>>> @@ -163,7 +163,7 @@ do
>>> done
>>>
>>> # Attempt to online all CPUs
>>> - for cpu in $( get_all_cpus ); do
>>> + for cpu in $( get_hotplug_cpus ); do
>>> if [ "$cpu" = "cpu0" ]; then
>>> continue
>>> fi
>>
>> Given that now this loop runs over hotpluggable cpus, it seems there is
>> no reason to treat cpu0 specially in cpuhotplug0{1, 3, 4}.sh.
>
> I'm not sure we can remove it in 01, because then it would try to bring
> all offline and if all are hotpluggable it's going to fail.
> I'd ignore 01 for now, it's broken anyway and disabled in runtest file.
>
> 03 looks like it can be removed, 04 is fixed by your patch.
>
> Also, I'd prefer if those testcases would find suitable cpu to test
> as part of test, instead of relying on passed parameters - but
> I don't want to inflate this patchset even more now.

ok.