From: Christian Lanig <clanig@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/1] Add automated tests for shell lib
Date: Fri, 31 Aug 2018 17:24:08 +0200 [thread overview]
Message-ID: <cover.1535725022.git.clanig@suse.com> (raw)
In-Reply-To: <20180829172448.GA2960@dell5510>
The following patch adds the test cases by Petr Vorel. They can be executed by
automatically. doc/write-tests-for-shell-lib.txt describes how everything works.
The output tells whether each test has passed and when it failed, the diff is
printed.
I apologize for the badly formatted message I sent before and hope that this
time I used the right format options.
@Petr
> + It'd be nice to describe, how testing works - how to modify the output
> (in README.md or at least in commit message).
I am not sure that the text in doc/write-tests-for-shell-lib.txt should really
go in README.md. Probably just a link or something. But I can change it if
necessary.
In regard of the other comments, I have removed all double quotes where nothing
should go wrong as long as the person executing the script doesn't have
unsupported file or directory naming or pretty uncommon bugs in his or her
shell.
I have also removed unnecessary else statements (which I thought would be
necessary to stay compatible but this appeared to be a wrong impression when I
read the text about it more accurately a second time).
Also a -h / --help option was added which should be explanatory enough for
people who intuitively run the script with this option and to replace comments
about functionality in the header of the script file.
Another feature is to specify single test cases as arguments to only run these
and no other.
Both outputs, the desired and the actual one, are now stored in a temporary
folder and the PATH environment variable is modified temporarily, which implied
the necessity to add a cleanup function.
Regards,
Christian
Christian Lanig (1):
Add automated tests for shell lib
doc/write-tests-for-shell-lib.txt | 61 ++++++++++++
.../shell/test.TST_TEST.TST_CNT.separate.sh | 29 ++++++
lib/newlib_tests/shell/test.TST_TEST.TST_CNT.sh | 27 ++++++
lib/newlib_tests/shell/test.TST_TEST.getopts.sh | 48 ++++++++++
lib/newlib_tests/shell/test.TST_TEST.sh | 32 +++++++
.../shell/test.TST_TEST_DATA.TST_CNT.separate.sh | 32 +++++++
.../shell/test.TST_TEST_DATA.TST_CNT.sh | 30 ++++++
.../shell/test.TST_TEST_DATA.getopts.sh | 50 ++++++++++
lib/newlib_tests/shell/test.TST_TEST_DATA.sh | 24 +++++
.../shell/test.TST_TEST_DATA_IFS.getopts.sh | 52 ++++++++++
lib/newlib_tests/shell/test.TST_TEST_DATA_IFS.sh | 27 ++++++
lib/newlib_tests/test_sh_newlib.sh | 105 +++++++++++++++++++++
12 files changed, 517 insertions(+)
create mode 100644 doc/write-tests-for-shell-lib.txt
create mode 100755 lib/newlib_tests/shell/test.TST_TEST.TST_CNT.separate.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST.TST_CNT.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST.getopts.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA.TST_CNT.separate.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA.TST_CNT.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA.getopts.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA_IFS.getopts.sh
create mode 100755 lib/newlib_tests/shell/test.TST_TEST_DATA_IFS.sh
create mode 100755 lib/newlib_tests/test_sh_newlib.sh
--
2.16.4
next prev parent reply other threads:[~2018-08-31 15:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:34 [LTP] [RFC PATCH v3 1/2] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS Petr Vorel
2018-05-22 19:34 ` [LTP] [RFC PATCH v3 2/2] lib: Add tests Petr Vorel
2018-05-24 13:46 ` Cyril Hrubis
2018-05-24 14:00 ` Petr Vorel
2018-08-28 11:18 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Christian Lanig
2018-08-28 11:18 ` [LTP] [PATCH 2/2] Add wanted output to shell lib test case Christian Lanig
2018-08-29 17:24 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Petr Vorel
2018-08-29 17:30 ` Petr Vorel
2018-08-31 15:24 ` Christian Lanig [this message]
2018-08-31 15:24 ` [LTP] [RFC PATCH 1/1] Add automated tests for shell lib Christian Lanig
2018-10-03 9:51 ` Cyril Hrubis
2018-10-03 10:46 ` Petr Vorel
2018-10-03 11:32 ` Petr Vorel
2019-08-22 19:12 ` [LTP] [RFC PATCH v2 0/1] " Christian Lanig
2019-08-22 19:12 ` [LTP] [RFC PATCH v2 1/1] " Christian Lanig
2019-09-19 16:41 ` Petr Vorel
2019-09-30 18:27 ` Christian Lanig
2019-09-20 14:21 ` Clemens Famulla-Conrad
2019-09-19 14:26 ` [LTP] [RFC PATCH v2 0/1] " Petr Vorel
2018-08-31 11:46 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Cyril Hrubis
2018-05-24 13:41 ` [LTP] [RFC PATCH v3 1/2] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS Cyril Hrubis
2018-05-24 13:53 ` Petr Vorel
2018-05-24 14:00 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1535725022.git.clanig@suse.com \
--to=clanig@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox