From: Christian Lanig <clanig@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 0/1] Add automated tests for shell lib
Date: Thu, 22 Aug 2019 21:12:44 +0200 [thread overview]
Message-ID: <cover.1566500817.git.clanig@suse.com> (raw)
In-Reply-To: <20181003113215.GB21139@dell5510>
Hi,
I am sorry that my reply took so long. Thank you very much for your comments
which helped me to improve the code.
I have made an overhaul of the code based on your suggestions but an option to
pass parameters to the tests is still not implemented.
I'm sending you what I have so far because it would help me when you could
provide me more information regarding this.
I agree that it is difficult to find a way to process text the way needed here
without disregarding the Linux Kernel Coding Style that asks for code which is
transparent and easy to read when we only consider Shell commands. To address
this issue I have drafted a Python script that might go in the tools folder and
may perhaps be helpful in other cases as well. Since there are already Python
files in the project it might be a valid option.
Thank you very much for your patience.
Regards,
Christian Lanig
Christian Lanig (1):
Add automated tests for shell lib
doc/write-tests-for-shell-lib.txt | 59 ++++++++++
lib/newlib_tests/shell/test_sh_newlib.sh | 102 ++++++++++++++++++
.../testcases/test.TST_TEST.TST_CNT.separate.sh | 30 ++++++
.../shell/testcases/test.TST_TEST.TST_CNT.sh | 28 +++++
.../shell/testcases/test.TST_TEST.getopts.sh | 49 +++++++++
lib/newlib_tests/shell/testcases/test.TST_TEST.sh | 33 ++++++
.../test.TST_TEST_DATA.TST_CNT.separate.sh | 33 ++++++
.../shell/testcases/test.TST_TEST_DATA.TST_CNT.sh | 31 ++++++
.../shell/testcases/test.TST_TEST_DATA.getopts.sh | 51 +++++++++
.../shell/testcases/test.TST_TEST_DATA.sh | 25 +++++
.../testcases/test.TST_TEST_DATA_IFS.getopts.sh | 53 +++++++++
.../shell/testcases/test.TST_TEST_DATA_IFS.sh | 28 +++++
tools/lookup_split_cut.py | 120 +++++++++++++++++++++
13 files changed, 642 insertions(+)
create mode 100644 doc/write-tests-for-shell-lib.txt
create mode 100755 lib/newlib_tests/shell/test_sh_newlib.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST.TST_CNT.separate.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST.TST_CNT.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST.getopts.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA.TST_CNT.separate.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA.TST_CNT.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA.getopts.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA_IFS.getopts.sh
create mode 100755 lib/newlib_tests/shell/testcases/test.TST_TEST_DATA_IFS.sh
create mode 100755 tools/lookup_split_cut.py
--
2.16.4
next prev parent reply other threads:[~2019-08-22 19:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:34 [LTP] [RFC PATCH v3 1/2] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS Petr Vorel
2018-05-22 19:34 ` [LTP] [RFC PATCH v3 2/2] lib: Add tests Petr Vorel
2018-05-24 13:46 ` Cyril Hrubis
2018-05-24 14:00 ` Petr Vorel
2018-08-28 11:18 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Christian Lanig
2018-08-28 11:18 ` [LTP] [PATCH 2/2] Add wanted output to shell lib test case Christian Lanig
2018-08-29 17:24 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Petr Vorel
2018-08-29 17:30 ` Petr Vorel
2018-08-31 15:24 ` [LTP] [RFC PATCH 0/1] Add automated tests for shell lib Christian Lanig
2018-08-31 15:24 ` [LTP] [RFC PATCH 1/1] " Christian Lanig
2018-10-03 9:51 ` Cyril Hrubis
2018-10-03 10:46 ` Petr Vorel
2018-10-03 11:32 ` Petr Vorel
2019-08-22 19:12 ` Christian Lanig [this message]
2019-08-22 19:12 ` [LTP] [RFC PATCH v2 " Christian Lanig
2019-09-19 16:41 ` Petr Vorel
2019-09-30 18:27 ` Christian Lanig
2019-09-20 14:21 ` Clemens Famulla-Conrad
2019-09-19 14:26 ` [LTP] [RFC PATCH v2 0/1] " Petr Vorel
2018-08-31 11:46 ` [LTP] [PATCH 1/2] Make shell lib tests standalone Cyril Hrubis
2018-05-24 13:41 ` [LTP] [RFC PATCH v3 1/2] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS Cyril Hrubis
2018-05-24 13:53 ` Petr Vorel
2018-05-24 14:00 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1566500817.git.clanig@suse.com \
--to=clanig@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox