From: Viresh Kumar <viresh.kumar@linaro.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/5] syscalls: Remove incorrect usage of libc structures
Date: Tue, 19 May 2020 14:21:07 +0530 [thread overview]
Message-ID: <cover.1589877853.git.viresh.kumar@linaro.org> (raw)
Hi,
It is incorrect to use the libc structures (timespec, timeval, timex),
to the non-timex64 syscalls called via tst_syscall() as the kernel
expects the old structures in there and the libc structure definition
may change in the future.
Arnd: It was getting difficult to search for such instances and so I
searched it with following strings (search for files that use these
structures, as well as tst_syscall()) to catch the abuse, hope it covers
all cases.
git grep "struct timeval" `git grep -l tst_syscall`
git grep "struct timespec" `git grep -l tst_syscall`
git grep "struct timex" `git grep -l tst_syscall`
Viresh Kumar (5):
tst_safe_clocks: Remove safe_clock_adjtime()
syscalls: settimeofday: Use gettimeofday()
syscalls: Don't use tst_syscall() unnecessarily
syscalls: Don't pass struct timespec to tst_syscall()
syscalls: Don't pass struct timeval to tst_syscall()
include/tst_clocks.h | 8 ++++---
include/tst_safe_clocks.h | 18 ---------------
include/tst_timer.h | 6 +++++
lib/parse_opts.c | 3 +--
lib/tst_clocks.c | 6 ++---
lib/tst_test.c | 16 ++++++-------
lib/tst_timer.c | 23 ++++++++++++-------
lib/tst_timer_test.c | 2 +-
lib/tst_wallclock.c | 17 +++++++-------
testcases/cve/cve-2016-7117.c | 2 +-
.../syscalls/clock_adjtime/clock_adjtime.h | 5 ----
.../syscalls/gettimeofday/gettimeofday02.c | 3 ++-
.../syscalls/settimeofday/settimeofday01.c | 6 ++---
.../syscalls/settimeofday/settimeofday02.c | 2 +-
testcases/kernel/syscalls/stime/stime_var.h | 3 ++-
15 files changed, 57 insertions(+), 63 deletions(-)
--
2.25.0.rc1.19.g042ed3e048af
next reply other threads:[~2020-05-19 8:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 8:51 Viresh Kumar [this message]
2020-05-19 8:51 ` [LTP] [PATCH 1/5] tst_safe_clocks: Remove safe_clock_adjtime() Viresh Kumar
2020-05-19 8:51 ` [LTP] [PATCH 2/5] syscalls: settimeofday: Use gettimeofday() Viresh Kumar
2020-05-19 9:20 ` Arnd Bergmann
2020-05-19 9:25 ` Viresh Kumar
2020-05-19 10:24 ` Arnd Bergmann
2020-05-19 12:16 ` Cyril Hrubis
2020-05-19 12:47 ` Arnd Bergmann
2020-05-20 7:16 ` Viresh Kumar
2020-05-21 13:16 ` Cyril Hrubis
2020-05-19 8:51 ` [LTP] [PATCH 3/5] syscalls: Don't use tst_syscall() unnecessarily Viresh Kumar
2020-05-19 9:22 ` Arnd Bergmann
2020-05-19 9:28 ` Viresh Kumar
2020-05-19 12:23 ` Cyril Hrubis
2020-05-19 12:41 ` Arnd Bergmann
2020-05-19 12:56 ` Petr Vorel
2020-05-19 13:45 ` Cyril Hrubis
2020-05-20 7:19 ` Viresh Kumar
2020-05-21 14:20 ` Cyril Hrubis
2020-05-21 15:10 ` Arnd Bergmann
2020-05-19 8:51 ` [LTP] [PATCH 4/5] syscalls: Don't pass struct timespec to tst_syscall() Viresh Kumar
2020-05-19 12:21 ` Cyril Hrubis
2020-05-20 7:31 ` Viresh Kumar
2020-05-20 8:47 ` Arnd Bergmann
2020-05-20 9:05 ` Viresh Kumar
2020-05-20 9:35 ` Arnd Bergmann
2020-05-20 9:39 ` Viresh Kumar
2020-05-20 9:52 ` Arnd Bergmann
2020-05-19 8:51 ` [LTP] [PATCH 5/5] syscalls: Don't pass struct timeval " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1589877853.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox