[LTP] [PATCH] configure.ac: Fix --with* options

Li Wang
2019-11-14T08:36:47Z

On Thu, Nov 14, 2019 at 4:09 PM Joerg Vehlow <lkml@jv-coder.de> wrote:

> Hi,
> >
> > Defining AC_ARG_WITH within an if to express dependencies does not
> > work.
> > ./configure --with-realtime-testsuite set
> with_realtime_testsuite=yes,
> > even if with_bash=no or with_python=no. The check is removed
> > completely.
> >
> >
> > Or, maybe we can make use of AS_IF here? and I noticed there are many
> > places that use "if test ..." in the configure.ac
> > <http://configure.ac> file. That looks tangly...
> I left a TODO in there so it can be fixed later, maybe together with
> other errors. I think this does not block merging this patch first?
>

Well, I just saw adding new #TODO here and hoping to solve this together, a
simple way I was thinking is:

+AS_IF([test "x$with_bash" != xyes || test "x$with_python" != xyes],
+ [with_realtime_testsuite=no]
+)

Of course, It's fine to fix that in a separate patch!

> The python requirement for realtime-testsuite is outdated/wrong anyway,
> if I remember correctly. A colleague of mine recently
> investigated the python requirement and we came to the conclusion, that
> it is not needed for running the test.
> I think it was used only for manual test result evaluation.

> So there seems to be more work regarding dependencies between configure
> options.
>

Yes, thanks for investigating this. Looking forward to more patches :).

For this one:
Reviewed-by: Li Wang <liwang@redhat.com>

--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20191114/00f1db0f/attachment.htm>