public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] shell: Add checkpoints api for new lib
Date: Wed, 11 Aug 2021 17:19:44 +0200	[thread overview]
Message-ID: <e8325b2c-36b3-a865-d48a-7ad5a8a095cb@jv-coder.de> (raw)
In-Reply-To: <YRPGHBuKHnvARkn+@yuki>

Hi Cyril,

On 8/11/2021 2:44 PM, Cyril Hrubis wrote:
>
>> +_tst_init_checkpoints()
>> +{
>> +	local pagesize
>> +
>> +	LTP_IPC_PATH="/dev/shm/ltp_${TCID}_$$"
>> +	pagesize=$(tst_getconf PAGESIZE)
>> +	if [ $? -ne 0 ]; then
>> +		tst_brk TBROK "tst_getconf PAGESIZE failed"
>> +	fi
>> +	ROD_SILENT dd if=/dev/zero of="$LTP_IPC_PATH" bs="$pagesize" count=1
>> +	ROD_SILENT chmod 600 "$LTP_IPC_PATH"
>> +	export LTP_IPC_PATH
>> +}
> Shouldn't we also delete the /dev/shm/ltp_${TCID}_$$ in the
> _tst_do_exit() if LTP_IPC_PATH was set?
You are right of course... I was in a tst_tmpdir mindset when 
implementing it, sorry.
I'll send a v2
>
> Other than that it looks fine.

Joerg

      reply	other threads:[~2021-08-11 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 12:12 [LTP] [PATCH 1/2] shell: Add checkpoints api for new lib Joerg Vehlow
2021-08-09 12:12 ` [LTP] [PATCH 2/2] pec: Improve reliability Joerg Vehlow
2021-08-11 12:44 ` [LTP] [PATCH 1/2] shell: Add checkpoints api for new lib Cyril Hrubis
2021-08-11 15:19   ` Joerg Vehlow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8325b2c-36b3-a865-d48a-7ad5a8a095cb@jv-coder.de \
    --to=lkml@jv-coder.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox