Re: [LTP] [PATCH v4 1/2] doc: generate CVE catalog documentation

[Sachin Sant <sachinp@linux.ibm.com>]

On 06/05/26 10:17 pm, Cyril Hrubis wrote:
> Hi!
>> -	rm -rf html/ build/ _static/syscalls.rst _static/tests.rst syscalls.tbl \
>> +	rm -rf html/ build/ _static/syscalls.rst _static/tests.rst _static/cve.rst syscalls.tbl \
>>   		${abs_top_builddir}/metadata/ltp.json
> This shouldn't be added here. the ltp.json is cleaned up by the
> metadata/Makefile.
My bad, probably an oversight on my part. Will remove.
>> +    Generate CVE catalog in a single file. Parse runtest/cve file and
>> +    generate documentation with links to CVE databases and test sources.
>> +    Similar to test_catalog, creates a single _static/cve.rst file with
>> +    all CVE information.
>> +    """
>> +    output = '_static/cve.rst'
>> +    runtest_cve = '../runtest/cve'
> I do not like much that we depend on the cve runtest file, we want to
> get rid of runtest files eventually and depend only on the ltp.json.
Ah I see. Thanks for the review. Will remove the dependency on runtest/cve.
>> +        text.extend([
>> +            f'   * - {cve_id}',
>> +            f'     - {test_link}',
>> +        ])
> Can we please instead iterate over the "tests" in the metadata here and
> collect all tests that have "CVE" key in "tags"?
>
> That should be more straightforward since we do not need to parse two
> files.
Sure, will rewrite the logic based on ltp.json metadata.
Will send an updated version of the patch.

-- 
Thanks
- Sachin



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp