From: Hongzhi, Song <hongzhi.song@windriver.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
Date: Thu, 11 Jul 2019 14:19:22 +0800 [thread overview]
Message-ID: <feec36ce-028b-50bb-9fde-626eb194dca9@windriver.com> (raw)
In-Reply-To: <1562824657-152321-1-git-send-email-hongzhi.song@windriver.com>
Commit log is not complete. I will send V2 later.
Please ignore this.
--Hongzhi
On 7/11/19 1:57 PM, Hongzhi.Song wrote:
> Error info:
> getrlimit03.c:104: FAIL: __NR_prlimit64(0) had rlim_cur =
> ffffffffffffffff but __NR_getrlimit(0) had rlim_cur = 7fffffff
>
> According to kernel code: RLIM_INFINITY is set to 0x7fffffffUL
> instead of ULONG_MAX on mips32.
>
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway,
> * but we keep the old value on MIPS32,
> * for compatibility:
> */
>
> Adding mips judgement code to fix this.
>
> Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> ---
> testcases/kernel/syscalls/getrlimit/getrlimit03.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getrlimit/getrlimit03.c b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> index e4d56c4..1903558 100644
> --- a/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> +++ b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> @@ -61,7 +61,13 @@ struct rlimit_ulong {
> unsigned long rlim_cur;
> unsigned long rlim_max;
> };
> +#ifdef __mips
> +#ifndef __mips64
> +const unsigned long RLIM_INFINITY_UL = 0x7fffffffUL;
> +#else
> const unsigned long RLIM_INFINITY_UL = ULONG_MAX;
> +#endif
> +#endif
>
> static int getrlimit_ulong(int resource, struct rlimit_ulong *rlim)
> {
> @@ -101,8 +107,8 @@ static int compare_u64_ulong(int resource, uint64_t val_u64,
> {
> if ((val_u64 > RLIM_INFINITY_UL && val_ul != RLIM_INFINITY_UL) ||
> (val_u64 <= RLIM_INFINITY_UL && val_ul != val_u64)) {
> - tst_res(TFAIL, "__NR_prlimit64(%d) had %s = %" PRIx64 " but " __NR_getrlimit_ulong_str "(%d) had %s = %lx",
> - resource, kind, val_u64,
> + tst_res(TFAIL, "SIGNED_GETRLIMIT = %d __WORDSIZE %d ULONG_MAX = %lu RLIM_INFINITY_UL = %lu __NR_prlimit64(%d) had %s = %" PRIx64 " but " __NR_getrlimit_ulong_str "(%d) had %s = %lx",
> + SIGNED_GETRLIMIT, __WORDSIZE, ULONG_MAX, RLIM_INFINITY_UL, resource, kind, val_u64,
> resource, kind, val_ul);
> return -1;
> }
next prev parent reply other threads:[~2019-07-11 6:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 5:57 [LTP] [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32 Hongzhi.Song
2019-07-11 6:19 ` Hongzhi, Song [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-16 9:04 [LTP] [PATCH V5] " Hongzhi.Song
2019-07-16 9:04 ` [LTP] [PATCH] " Hongzhi.Song
2019-07-17 8:36 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feec36ce-028b-50bb-9fde-626eb194dca9@windriver.com \
--to=hongzhi.song@windriver.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox