Re: [LTP] Openposix: pthread create, testcase 1-6

Re: [LTP] Openposix: pthread create, testcase 1-6

[vaibhav]

Mike Frysinger <vapier@...> writes:

> 
> On Monday 03 December 2007, Patrick Kirsch wrote:
> > I have a question on testcase pthread_create/1-1.c :
> > there is shared variable "int *ctrl = (int *) arg;" in function
> > "hp_func" which should be protected through pthread_mutex or similar,
> > right? As I understand this shared variable should always be protected?
> > So is there a reason why there are no pthread synchronisation calls?
> >
> > As you can see in the suggested temporary patch below, is it possible to
> > add volatile-statement to the shared variables?
> >
> > I'm asking, because sometimes this testcase fails on s390x.
> 
> perhaps look at the generated assembly code and see if gcc is incorrectly 
> optimizing away memory loads ?  adding volatile sounds like you're ignoring a 
> deeper problem ...
> -mike

Hi Mike

This test case is released with volatile variable usage in LTP january release. 
I tested it for MIPS target, it FAILS giving error : 

volatile int *ctrl = (int *) arg; 

Can you please point out whats could be the exact issue? 

Looking forward to your reply. 

Thanks,
Vaibhav 
> 
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> 
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Openposix: pthread create, testcase 1-6

[naresh kamboju]

Hi Vaibhav,

> Mike Frysinger <vapier@...> writes:
>
> >
> > On Monday 03 December 2007, Patrick Kirsch wrote:
> > > I have a question on testcase pthread_create/1-1.c :
> > > there is shared variable "int *ctrl = (int *) arg;" in function
> > > "hp_func" which should be protected through pthread_mutex or similar,
> > > right? As I understand this shared variable should always be protected?
> > > So is there a reason why there are no pthread synchronisation calls?
> > >
> > > As you can see in the suggested temporary patch below, is it possible to
> > > add volatile-statement to the shared variables?
> > >
> > > I'm asking, because sometimes this testcase fails on s390x.
> >
> > perhaps look at the generated assembly code and see if gcc is incorrectly
> > optimizing away memory loads ?  adding volatile sounds like you're ignoring a
> > deeper problem ...
> > -mike
>
> Hi Mike
>
> This test case is released with volatile variable usage in LTP january release.
> I tested it for MIPS target, it FAILS giving error :
>
> volatile int *ctrl = (int *) arg;
>
> Can you please point out whats could be the exact issue?
To understand problem in detail, please provide the Error log you are getting.
Are you not getting this FAIL error without volatile?
if the issue is only with MIPS, we need to understand MIPS compiler
difference from others.

IMHO, the test case is designed well.

Best regards
Naresh Kamboju

>
> Looking forward to your reply.
>
> Thanks,
> Vaibhav
> >
> >
> > -------------------------------------------------------------------------
> > SF.Net email is sponsored by: The Future of Linux Business White Paper
> > from Novell.  From the desktop to the data center, Linux is going
> > mainstream.  Let it simplify your IT future.
> > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> >
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@...
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> >
>
>

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list