* [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size
@ 2024-09-16 9:29 Andreas Schwab
2024-09-16 10:32 ` Jan Stancek
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2024-09-16 9:29 UTC (permalink / raw)
To: ltp
The linux_dirent and linux_dirent64 structs do not contain space for the
d_name member. Add NAME_MAX to the size in tst_dirp_size so that the
getdents syscalls do not spuriously fail with EINVAL instead of EFAULT.
---
testcases/kernel/syscalls/getdents/getdents.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/getdents/getdents.h b/testcases/kernel/syscalls/getdents/getdents.h
index 560df4126..02c3bc509 100644
--- a/testcases/kernel/syscalls/getdents/getdents.h
+++ b/testcases/kernel/syscalls/getdents/getdents.h
@@ -64,9 +64,9 @@ tst_dirp_size(void)
{
switch (tst_variant) {
case 0:
- return sizeof(struct linux_dirent);
+ return sizeof(struct linux_dirent) + NAME_MAX;
case 1:
- return sizeof(struct linux_dirent64);
+ return sizeof(struct linux_dirent64) + NAME_MAX;
#if HAVE_GETDENTS
case 2:
return sizeof(struct dirent);
--
2.46.1
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size
2024-09-16 9:29 [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size Andreas Schwab
@ 2024-09-16 10:32 ` Jan Stancek
0 siblings, 0 replies; 5+ messages in thread
From: Jan Stancek @ 2024-09-16 10:32 UTC (permalink / raw)
To: Andreas Schwab; +Cc: ltp
On Mon, Sep 16, 2024 at 11:30 AM Andreas Schwab <schwab@suse.de> wrote:
>
> The linux_dirent and linux_dirent64 structs do not contain space for the
> d_name member. Add NAME_MAX to the size in tst_dirp_size so that the
> getdents syscalls do not spuriously fail with EINVAL instead of EFAULT.
Signed-off-by seems missing.
Acked-by: Jan Stancek <jstancek@redhat.com>
> ---
> testcases/kernel/syscalls/getdents/getdents.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getdents/getdents.h b/testcases/kernel/syscalls/getdents/getdents.h
> index 560df4126..02c3bc509 100644
> --- a/testcases/kernel/syscalls/getdents/getdents.h
> +++ b/testcases/kernel/syscalls/getdents/getdents.h
> @@ -64,9 +64,9 @@ tst_dirp_size(void)
> {
> switch (tst_variant) {
> case 0:
> - return sizeof(struct linux_dirent);
> + return sizeof(struct linux_dirent) + NAME_MAX;
> case 1:
> - return sizeof(struct linux_dirent64);
> + return sizeof(struct linux_dirent64) + NAME_MAX;
> #if HAVE_GETDENTS
> case 2:
> return sizeof(struct dirent);
> --
> 2.46.1
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size
@ 2024-09-16 10:51 Andreas Schwab
2024-09-16 11:15 ` Jan Stancek
2024-09-16 12:09 ` Cyril Hrubis
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Schwab @ 2024-09-16 10:51 UTC (permalink / raw)
To: ltp
The linux_dirent and linux_dirent64 structs do not contain space for the
d_name member. Add NAME_MAX to the size in tst_dirp_size so that the
getdents syscalls do not spuriously fail with EINVAL instead of EFAULT.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
testcases/kernel/syscalls/getdents/getdents.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/getdents/getdents.h b/testcases/kernel/syscalls/getdents/getdents.h
index 560df4126..02c3bc509 100644
--- a/testcases/kernel/syscalls/getdents/getdents.h
+++ b/testcases/kernel/syscalls/getdents/getdents.h
@@ -64,9 +64,9 @@ tst_dirp_size(void)
{
switch (tst_variant) {
case 0:
- return sizeof(struct linux_dirent);
+ return sizeof(struct linux_dirent) + NAME_MAX;
case 1:
- return sizeof(struct linux_dirent64);
+ return sizeof(struct linux_dirent64) + NAME_MAX;
#if HAVE_GETDENTS
case 2:
return sizeof(struct dirent);
--
2.46.1
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size
2024-09-16 10:51 Andreas Schwab
@ 2024-09-16 11:15 ` Jan Stancek
2024-09-16 12:09 ` Cyril Hrubis
1 sibling, 0 replies; 5+ messages in thread
From: Jan Stancek @ 2024-09-16 11:15 UTC (permalink / raw)
To: Andreas Schwab; +Cc: ltp
On Mon, Sep 16, 2024 at 12:51 PM Andreas Schwab <schwab@suse.de> wrote:
>
> The linux_dirent and linux_dirent64 structs do not contain space for the
> d_name member. Add NAME_MAX to the size in tst_dirp_size so that the
> getdents syscalls do not spuriously fail with EINVAL instead of EFAULT.
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Acked-by: Jan Stancek <jstancek@redhat.com>
> ---
> testcases/kernel/syscalls/getdents/getdents.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getdents/getdents.h b/testcases/kernel/syscalls/getdents/getdents.h
> index 560df4126..02c3bc509 100644
> --- a/testcases/kernel/syscalls/getdents/getdents.h
> +++ b/testcases/kernel/syscalls/getdents/getdents.h
> @@ -64,9 +64,9 @@ tst_dirp_size(void)
> {
> switch (tst_variant) {
> case 0:
> - return sizeof(struct linux_dirent);
> + return sizeof(struct linux_dirent) + NAME_MAX;
> case 1:
> - return sizeof(struct linux_dirent64);
> + return sizeof(struct linux_dirent64) + NAME_MAX;
> #if HAVE_GETDENTS
> case 2:
> return sizeof(struct dirent);
> --
> 2.46.1
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size
2024-09-16 10:51 Andreas Schwab
2024-09-16 11:15 ` Jan Stancek
@ 2024-09-16 12:09 ` Cyril Hrubis
1 sibling, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2024-09-16 12:09 UTC (permalink / raw)
To: Andreas Schwab; +Cc: ltp
Hi!
Applied, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-16 12:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-16 9:29 [LTP] [PATCH] getdents: account for d_name size in tst_dirp_size Andreas Schwab
2024-09-16 10:32 ` Jan Stancek
-- strict thread matches above, loose matches on Subject: below --
2024-09-16 10:51 Andreas Schwab
2024-09-16 11:15 ` Jan Stancek
2024-09-16 12:09 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox