public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] lchown test case
@ 2010-01-04 15:10 Michal Simek
  2010-01-06  1:27 ` Jiri Palecek
  0 siblings, 1 reply; 10+ messages in thread
From: Michal Simek @ 2010-01-04 15:10 UTC (permalink / raw)
  To: Garrett Cooper, ltp-list@lists.sourceforge.net

Hi,

I have some problems with lchown02 test which is caused with this patch.
What is prep_create_link?

Thanks,
Michal

http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038


diff --git a/runtest/syscalls b/runtest/syscalls
index fbe8641..34631ed 100644 (file)
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -462,10 +462,10 @@ kill12 kill12

  lchown01 lchown01
  lchown01_16 lchown01_16
-lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
-lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
+lchown02 prep_create_link; lchown02
+lchown02_16 prep_create_link; lchown02_16

-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-04 15:10 [LTP] lchown test case Michal Simek
@ 2010-01-06  1:27 ` Jiri Palecek
  2010-01-06  1:41   ` Garrett Cooper
  0 siblings, 1 reply; 10+ messages in thread
From: Jiri Palecek @ 2010-01-06  1:27 UTC (permalink / raw)
  To: michal.simek; +Cc: ltp-list@lists.sourceforge.net

Michal Simek napsal(a):
> Hi,

Hi,
>
> I have some problems with lchown02 test which is caused with this patch.
> What is prep_create_link?
>
> Thanks,
> Michal
>
> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>
>
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index fbe8641..34631ed 100644 (file)
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -462,10 +462,10 @@ kill12 kill12
>
> lchown01 lchown01
> lchown01_16 lchown01_16
> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
> +lchown02 prep_create_link; lchown02
> +lchown02_16 prep_create_link; lchown02_16

IMHO it should do the same as the line above. But I think the whole thing could 
be deleted without causing any grief:

http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82

Regards
     Jiri Palecek



------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-06  1:27 ` Jiri Palecek
@ 2010-01-06  1:41   ` Garrett Cooper
  2010-01-06  2:31     ` Garrett Cooper
  0 siblings, 1 reply; 10+ messages in thread
From: Garrett Cooper @ 2010-01-06  1:41 UTC (permalink / raw)
  To: Jiri Palecek; +Cc: ltp-list@lists.sourceforge.net

On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek <jpalecek@web.de> wrote:
> Michal Simek napsal(a):
>>
>> Hi,
>
> Hi,
>>
>> I have some problems with lchown02 test which is caused with this patch.
>> What is prep_create_link?
>>
>> Thanks,
>> Michal
>>
>>
>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>
>>
>>
>> diff --git a/runtest/syscalls b/runtest/syscalls
>> index fbe8641..34631ed 100644 (file)
>> --- a/runtest/syscalls
>> +++ b/runtest/syscalls
>> @@ -462,10 +462,10 @@ kill12 kill12
>>
>> lchown01 lchown01
>> lchown01_16 lchown01_16
>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>> +lchown02 prep_create_link; lchown02
>> +lchown02_16 prep_create_link; lchown02_16
>
> IMHO it should do the same as the line above. But I think the whole thing
> could be deleted without causing any grief:
>
> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82

The test needs create_link in $TMP; that's why I scripted it as a
one-liner (but stupid me probably forgot to add the script to CVS
-_-).
Let me look and I'll get back to you shortly.
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-06  1:41   ` Garrett Cooper
@ 2010-01-06  2:31     ` Garrett Cooper
  2010-01-06 12:13       ` Michal Simek
  2010-01-07  1:33       ` Jiri Palecek
  0 siblings, 2 replies; 10+ messages in thread
From: Garrett Cooper @ 2010-01-06  2:31 UTC (permalink / raw)
  To: Jiri Palecek; +Cc: ltp-list@lists.sourceforge.net

On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek <jpalecek@web.de> wrote:
>> Michal Simek napsal(a):
>>>
>>> Hi,
>>
>> Hi,
>>>
>>> I have some problems with lchown02 test which is caused with this patch.
>>> What is prep_create_link?
>>>
>>> Thanks,
>>> Michal
>>>
>>>
>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>
>>>
>>>
>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>> index fbe8641..34631ed 100644 (file)
>>> --- a/runtest/syscalls
>>> +++ b/runtest/syscalls
>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>
>>> lchown01 lchown01
>>> lchown01_16 lchown01_16
>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>> +lchown02 prep_create_link; lchown02
>>> +lchown02_16 prep_create_link; lchown02_16
>>
>> IMHO it should do the same as the line above. But I think the whole thing
>> could be deleted without causing any grief:
>>
>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>
> The test needs create_link in $TMP; that's why I scripted it as a
> one-liner (but stupid me probably forgot to add the script to CVS
> -_-).
> Let me look and I'll get back to you shortly.

Fixed. The executable needed CAP_CHOWN capability and that's part of
the point behind that script...
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-06  2:31     ` Garrett Cooper
@ 2010-01-06 12:13       ` Michal Simek
  2010-01-06 19:24         ` Garrett Cooper
  2010-01-07  1:33       ` Jiri Palecek
  1 sibling, 1 reply; 10+ messages in thread
From: Michal Simek @ 2010-01-06 12:13 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: Jiri Palecek, ltp-list@lists.sourceforge.net

Garrett Cooper wrote:
> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek <jpalecek@web.de> wrote:
>>> Michal Simek napsal(a):
>>>> Hi,
>>> Hi,
>>>> I have some problems with lchown02 test which is caused with this patch.
>>>> What is prep_create_link?
>>>>
>>>> Thanks,
>>>> Michal
>>>>
>>>>
>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>
>>>>
>>>>
>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>> index fbe8641..34631ed 100644 (file)
>>>> --- a/runtest/syscalls
>>>> +++ b/runtest/syscalls
>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>
>>>> lchown01 lchown01
>>>> lchown01_16 lchown01_16
>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>>> +lchown02 prep_create_link; lchown02
>>>> +lchown02_16 prep_create_link; lchown02_16
>>> IMHO it should do the same as the line above. But I think the whole thing
>>> could be deleted without causing any grief:
>>>
>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>> The test needs create_link in $TMP; that's why I scripted it as a
>> one-liner (but stupid me probably forgot to add the script to CVS
>> -_-).
>> Let me look and I'll get back to you shortly.
> 
> Fixed. The executable needed CAP_CHOWN capability and that's part of
> the point behind that script...

ok. I rerun the latest code and lchown02 testcases still failing.
I added two printf messages (path:Path_name -  and buffer:Cmd_buffer) 
which you can see below. And remove tst_rmdir to see if file exist or not.


path /tmp/ltp-XXXX1ZaUjj/lch6m6mr0
buffer /mnt/4/ltp/build/testcases/bin/create_link 
/tmp/ltp-XXXX1ZaUjj/lch6m6mr0/tfile_1
change_owner: chown() of /tmp/ltp-XXXX1ZaUjj/lch6m6mr0/tfile_1 failed, 
error 1
lchown02    1  TBROK  :  Fail to modify tfile_1 ownership(s)!
lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken
path /tmp/ltp-XXXX1ZaUjj/lchouwHqq
buffer /mnt/4/ltp/build/testcases/bin/create_link 
/tmp/ltp-XXXX1ZaUjj/lchouwHqq/tfile_1
change_owner: chown() of /tmp/ltp-XXXX1ZaUjj/lchouwHqq/tfile_1 failed, 
error 1
lchown02    1  TBROK  :  Fail to modify tfile_1 ownership(s)!
lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken


The problem is at first with create_link because there is used 
/mnt/4/ltp/build/testcases/bin/create_link instead of 
/tmp/ltp-XXXX1ZaUjj/create_link which is setup by prep_create_link

Please test the patch below which run correct version on my system

Then I tried to run lchown02 test under user and I think that this line 
in prep_create_link is addtional
#chown root:root "$TMP/create_link"

lchown test must be run under root that's why create_link will have root 
rights and under user test reports that must be run as root.

lchown02    1  TBROK  :  Test must be run as root
lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken
lchown02    1  TBROK  :  Test must be run as root
lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken


Thanks for testing,
Michal


--- lchown02-old.c      2010-01-06 12:59:32.000000000 +0100
+++ lchown02.c  2010-01-06 13:00:49.000000000 +0100
@@ -112,7 +112,6 @@
  char Longpathname[PATH_MAX + 2];
  char High_address_node[64];
  char EXEC_DIR[PATH_MAX];
-char main_test_dir[PATH_MAX + 2];

  struct test_case_t {           /* test case struct. to hold ref. test 
cond's */
         char *pathname;
@@ -265,12 +264,6 @@
         /* Pause if that option was specified */
         TEST_PAUSE;

-       /* remember current dir, because create_link has been copied here */
-       if (getcwd(main_test_dir, sizeof(main_test_dir)) == NULL) {
-               tst_brkm(TBROK | TERRNO, cleanup,
-                        "failed to get the current working directory.");
-       }
-
         /* Make a temp dir and cd to it */
         tst_tmpdir();

@@ -339,12 +332,13 @@

         strcpy(Path2_name, Path_name);

+       /* Get the command name to be executed as setuid to root */
+       strcat((char *)Cmd_buffer, Path_name);
+       strcat((char *)Cmd_buffer, (const char *)"/../create_link ");
+
         /* Get the path of test file created under temporary directory */
         strcat(Path_name, "/" TEST_FILE1);

-       /* Get the command name to be executed as setuid to root */
-       strcat((char *)Cmd_buffer, main_test_dir);
-       strcat((char *)Cmd_buffer, (const char *)"/create_link ");
         strcat((char *)Cmd_buffer, Path_name);

         if (system((const char *)Cmd_buffer) != 0) {






> -Garrett


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-06 12:13       ` Michal Simek
@ 2010-01-06 19:24         ` Garrett Cooper
  0 siblings, 0 replies; 10+ messages in thread
From: Garrett Cooper @ 2010-01-06 19:24 UTC (permalink / raw)
  To: michal.simek; +Cc: Jiri Palecek, ltp-list@lists.sourceforge.net

On Wed, Jan 6, 2010 at 4:13 AM, Michal Simek <michal.simek@petalogix.com> wrote:
> Garrett Cooper wrote:
>>
>> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>>>
>>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek <jpalecek@web.de> wrote:
>>>>
>>>> Michal Simek napsal(a):
>>>>>
>>>>> Hi,
>>>>
>>>> Hi,
>>>>>
>>>>> I have some problems with lchown02 test which is caused with this
>>>>> patch.
>>>>> What is prep_create_link?
>>>>>
>>>>> Thanks,
>>>>> Michal
>>>>>
>>>>>
>>>>>
>>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>>
>>>>>
>>>>>
>>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>>> index fbe8641..34631ed 100644 (file)
>>>>> --- a/runtest/syscalls
>>>>> +++ b/runtest/syscalls
>>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>>
>>>>> lchown01 lchown01
>>>>> lchown01_16 lchown01_16
>>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>>>> +lchown02 prep_create_link; lchown02
>>>>> +lchown02_16 prep_create_link; lchown02_16
>>>>
>>>> IMHO it should do the same as the line above. But I think the whole
>>>> thing
>>>> could be deleted without causing any grief:
>>>>
>>>>
>>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>>>
>>> The test needs create_link in $TMP; that's why I scripted it as a
>>> one-liner (but stupid me probably forgot to add the script to CVS
>>> -_-).
>>> Let me look and I'll get back to you shortly.
>>
>> Fixed. The executable needed CAP_CHOWN capability and that's part of
>> the point behind that script...
>
> ok. I rerun the latest code and lchown02 testcases still failing.
> I added two printf messages (path:Path_name -  and buffer:Cmd_buffer) which
> you can see below. And remove tst_rmdir to see if file exist or not.
>
>
> path /tmp/ltp-XXXX1ZaUjj/lch6m6mr0
> buffer /mnt/4/ltp/build/testcases/bin/create_link
> /tmp/ltp-XXXX1ZaUjj/lch6m6mr0/tfile_1
> change_owner: chown() of /tmp/ltp-XXXX1ZaUjj/lch6m6mr0/tfile_1 failed, error
> 1
> lchown02    1  TBROK  :  Fail to modify tfile_1 ownership(s)!
> lchown02    2  TBROK  :  Remaining cases broken
> lchown02    3  TBROK  :  Remaining cases broken
> lchown02    4  TBROK  :  Remaining cases broken
> lchown02    5  TBROK  :  Remaining cases broken
> lchown02    6  TBROK  :  Remaining cases broken
> lchown02    7  TBROK  :  Remaining cases broken
> path /tmp/ltp-XXXX1ZaUjj/lchouwHqq
> buffer /mnt/4/ltp/build/testcases/bin/create_link
> /tmp/ltp-XXXX1ZaUjj/lchouwHqq/tfile_1
> change_owner: chown() of /tmp/ltp-XXXX1ZaUjj/lchouwHqq/tfile_1 failed, error
> 1
> lchown02    1  TBROK  :  Fail to modify tfile_1 ownership(s)!
> lchown02    2  TBROK  :  Remaining cases broken
> lchown02    3  TBROK  :  Remaining cases broken
> lchown02    4  TBROK  :  Remaining cases broken
> lchown02    5  TBROK  :  Remaining cases broken
> lchown02    6  TBROK  :  Remaining cases broken
> lchown02    7  TBROK  :  Remaining cases broken
>
>
> The problem is at first with create_link because there is used
> /mnt/4/ltp/build/testcases/bin/create_link instead of
> /tmp/ltp-XXXX1ZaUjj/create_link which is setup by prep_create_link
>
> Please test the patch below which run correct version on my system
>
> Then I tried to run lchown02 test under user and I think that this line in
> prep_create_link is addtional
> #chown root:root "$TMP/create_link"
>
> lchown test must be run under root that's why create_link will have root
> rights and under user test reports that must be run as root.
>
> lchown02    1  TBROK  :  Test must be run as root
> lchown02    2  TBROK  :  Remaining cases broken
> lchown02    3  TBROK  :  Remaining cases broken
> lchown02    4  TBROK  :  Remaining cases broken
> lchown02    5  TBROK  :  Remaining cases broken
> lchown02    6  TBROK  :  Remaining cases broken
> lchown02    7  TBROK  :  Remaining cases broken
> lchown02    1  TBROK  :  Test must be run as root
> lchown02    2  TBROK  :  Remaining cases broken
> lchown02    3  TBROK  :  Remaining cases broken
> lchown02    4  TBROK  :  Remaining cases broken
> lchown02    5  TBROK  :  Remaining cases broken
> lchown02    6  TBROK  :  Remaining cases broken
> lchown02    7  TBROK  :  Remaining cases broken
>
>
> Thanks for testing,
> Michal
>
>
> --- lchown02-old.c      2010-01-06 12:59:32.000000000 +0100
> +++ lchown02.c  2010-01-06 13:00:49.000000000 +0100
> @@ -112,7 +112,6 @@
>  char Longpathname[PATH_MAX + 2];
>  char High_address_node[64];
>  char EXEC_DIR[PATH_MAX];
> -char main_test_dir[PATH_MAX + 2];
>
>  struct test_case_t {           /* test case struct. to hold ref. test
> cond's */
>        char *pathname;
> @@ -265,12 +264,6 @@
>        /* Pause if that option was specified */
>        TEST_PAUSE;
>
> -       /* remember current dir, because create_link has been copied here */
> -       if (getcwd(main_test_dir, sizeof(main_test_dir)) == NULL) {
> -               tst_brkm(TBROK | TERRNO, cleanup,
> -                        "failed to get the current working directory.");
> -       }
> -
>        /* Make a temp dir and cd to it */
>        tst_tmpdir();
>
> @@ -339,12 +332,13 @@
>
>        strcpy(Path2_name, Path_name);
>
> +       /* Get the command name to be executed as setuid to root */
> +       strcat((char *)Cmd_buffer, Path_name);
> +       strcat((char *)Cmd_buffer, (const char *)"/../create_link ");
> +
>        /* Get the path of test file created under temporary directory */
>        strcat(Path_name, "/" TEST_FILE1);
>
> -       /* Get the command name to be executed as setuid to root */
> -       strcat((char *)Cmd_buffer, main_test_dir);
> -       strcat((char *)Cmd_buffer, (const char *)"/create_link ");
>        strcat((char *)Cmd_buffer, Path_name);
>
>        if (system((const char *)Cmd_buffer) != 0) {

    I'll look at this and resolve it tonight, but I think your
solution is correct... I just need to look at the source a bit
better...
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-06  2:31     ` Garrett Cooper
  2010-01-06 12:13       ` Michal Simek
@ 2010-01-07  1:33       ` Jiri Palecek
  2010-01-07  5:57         ` Garrett Cooper
  1 sibling, 1 reply; 10+ messages in thread
From: Jiri Palecek @ 2010-01-07  1:33 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: ltp-list@lists.sourceforge.net

Garrett Cooper napsal(a):
> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper<yanegomi@gmail.com>  wrote:
>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek<jpalecek@web.de>  wrote:
>>> Michal Simek napsal(a):
>>>>
>>>> Hi,
>>>
>>> Hi,
>>>>
>>>> I have some problems with lchown02 test which is caused with this patch.
>>>> What is prep_create_link?
>>>>
>>>> Thanks,
>>>> Michal
>>>>
>>>>
>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>
>>>>
>>>>
>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>> index fbe8641..34631ed 100644 (file)
>>>> --- a/runtest/syscalls
>>>> +++ b/runtest/syscalls
>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>
>>>> lchown01 lchown01
>>>> lchown01_16 lchown01_16
>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>>> +lchown02 prep_create_link; lchown02
>>>> +lchown02_16 prep_create_link; lchown02_16
>>>
>>> IMHO it should do the same as the line above. But I think the whole thing
>>> could be deleted without causing any grief:
>>>
>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>>
>> The test needs create_link in $TMP; that's why I scripted it as a
>> one-liner (but stupid me probably forgot to add the script to CVS
>> -_-).
>> Let me look and I'll get back to you shortly.
>
> Fixed. The executable needed CAP_CHOWN capability and that's part of
> the point behind that script...

Couldn't the executable just get CAP_CHOWN with cap_set_proc in case it is 
running under root with restricted capabilities?

I'm not sure it wouldn't fail even with the suid-root executable under such 
condition - are you really sure it doesn't (esp. in the face of lchown01, which 
would fail almost surely and doesn't have this hack)?

Regards
     Jiri Palecek

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-07  1:33       ` Jiri Palecek
@ 2010-01-07  5:57         ` Garrett Cooper
  2010-01-07 14:02           ` Michal Simek
  0 siblings, 1 reply; 10+ messages in thread
From: Garrett Cooper @ 2010-01-07  5:57 UTC (permalink / raw)
  To: Jiri Palecek; +Cc: ltp-list@lists.sourceforge.net

On Wed, Jan 6, 2010 at 5:33 PM, Jiri Palecek <jpalecek@web.de> wrote:
> Garrett Cooper napsal(a):
>>
>> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper<yanegomi@gmail.com>  wrote:
>>>
>>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek<jpalecek@web.de>  wrote:
>>>>
>>>> Michal Simek napsal(a):
>>>>>
>>>>> Hi,
>>>>
>>>> Hi,
>>>>>
>>>>> I have some problems with lchown02 test which is caused with this
>>>>> patch.
>>>>> What is prep_create_link?
>>>>>
>>>>> Thanks,
>>>>> Michal
>>>>>
>>>>>
>>>>>
>>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>>
>>>>>
>>>>>
>>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>>> index fbe8641..34631ed 100644 (file)
>>>>> --- a/runtest/syscalls
>>>>> +++ b/runtest/syscalls
>>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>>
>>>>> lchown01 lchown01
>>>>> lchown01_16 lchown01_16
>>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>>>> +lchown02 prep_create_link; lchown02
>>>>> +lchown02_16 prep_create_link; lchown02_16
>>>>
>>>> IMHO it should do the same as the line above. But I think the whole
>>>> thing
>>>> could be deleted without causing any grief:
>>>>
>>>>
>>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>>>
>>> The test needs create_link in $TMP; that's why I scripted it as a
>>> one-liner (but stupid me probably forgot to add the script to CVS
>>> -_-).
>>> Let me look and I'll get back to you shortly.
>>
>> Fixed. The executable needed CAP_CHOWN capability and that's part of
>> the point behind that script...
>
> Couldn't the executable just get CAP_CHOWN with cap_set_proc in case it is
> running under root with restricted capabilities?
>
> I'm not sure it wouldn't fail even with the suid-root executable under such
> condition - are you really sure it doesn't (esp. in the face of lchown01,
> which would fail almost surely and doesn't have this hack)?

    This requires libcap though, which means that any system under
test without it would fail the test:

NAME
       cap_get_proc,  cap_set_proc,  capgetp - capability manipulation on pro-
       cesses

SYNOPSIS
       #include <sys/capability.h>

       cap_t cap_get_proc(void);

       int cap_set_proc(cap_t cap_p);

       #include <sys/types.h>

       cap_t cap_get_pid(pid_t pid);

       Link with -lcap.

    I agree though, this is the best / cleanest solution...
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-07  5:57         ` Garrett Cooper
@ 2010-01-07 14:02           ` Michal Simek
  2010-01-08 15:40             ` Jiří Paleček
  0 siblings, 1 reply; 10+ messages in thread
From: Michal Simek @ 2010-01-07 14:02 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: Jiri Palecek, ltp-list@lists.sourceforge.net

Garrett Cooper wrote:
> On Wed, Jan 6, 2010 at 5:33 PM, Jiri Palecek <jpalecek@web.de> wrote:
>> Garrett Cooper napsal(a):
>>> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper<yanegomi@gmail.com>  wrote:
>>>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek<jpalecek@web.de>  wrote:
>>>>> Michal Simek napsal(a):
>>>>>> Hi,
>>>>> Hi,
>>>>>> I have some problems with lchown02 test which is caused with this
>>>>>> patch.
>>>>>> What is prep_create_link?
>>>>>>
>>>>>> Thanks,
>>>>>> Michal
>>>>>>
>>>>>>
>>>>>>
>>>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>>>
>>>>>>
>>>>>>
>>>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>>>> index fbe8641..34631ed 100644 (file)
>>>>>> --- a/runtest/syscalls
>>>>>> +++ b/runtest/syscalls
>>>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>>>
>>>>>> lchown01 lchown01
>>>>>> lchown01_16 lchown01_16
>>>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02_16
>>>>>> +lchown02 prep_create_link; lchown02
>>>>>> +lchown02_16 prep_create_link; lchown02_16
>>>>> IMHO it should do the same as the line above. But I think the whole
>>>>> thing
>>>>> could be deleted without causing any grief:
>>>>>
>>>>>
>>>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>>>> The test needs create_link in $TMP; that's why I scripted it as a
>>>> one-liner (but stupid me probably forgot to add the script to CVS
>>>> -_-).
>>>> Let me look and I'll get back to you shortly.
>>> Fixed. The executable needed CAP_CHOWN capability and that's part of
>>> the point behind that script...
>> Couldn't the executable just get CAP_CHOWN with cap_set_proc in case it is
>> running under root with restricted capabilities?
>>
>> I'm not sure it wouldn't fail even with the suid-root executable under such
>> condition - are you really sure it doesn't (esp. in the face of lchown01,
>> which would fail almost surely and doesn't have this hack)?
> 
>     This requires libcap though, which means that any system under
> test without it would fail the test:
> 
> NAME
>        cap_get_proc,  cap_set_proc,  capgetp - capability manipulation on pro-
>        cesses
> 
> SYNOPSIS
>        #include <sys/capability.h>
> 
>        cap_t cap_get_proc(void);
> 
>        int cap_set_proc(cap_t cap_p);
> 
>        #include <sys/types.h>
> 
>        cap_t cap_get_pid(pid_t pid);
> 
>        Link with -lcap.
> 
>     I agree though, this is the best / cleanest solution...


Please keep in your mind that not everybody has capability.h in 
toolchain. For example we don't have it. I can imagine that this could 
be one option. You can check if is capability.h and then use it. But if 
is not there still should be able to run that tests.

Michal



> Thanks,
> -Garrett


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [LTP] lchown test case
  2010-01-07 14:02           ` Michal Simek
@ 2010-01-08 15:40             ` Jiří Paleček
  0 siblings, 0 replies; 10+ messages in thread
From: Jiří Paleček @ 2010-01-08 15:40 UTC (permalink / raw)
  To: michal.simek, Garrett Cooper; +Cc: ltp-list@lists.sourceforge.net

[-- Attachment #1: Type: text/plain, Size: 3699 bytes --]

On Thu, 07 Jan 2010 15:02:49 +0100, Michal Simek  
<michal.simek@petalogix.com> wrote:

> Garrett Cooper wrote:
>> On Wed, Jan 6, 2010 at 5:33 PM, Jiri Palecek <jpalecek@web.de> wrote:
>>> Garrett Cooper napsal(a):
>>>> On Tue, Jan 5, 2010 at 5:41 PM, Garrett Cooper<yanegomi@gmail.com>   
>>>> wrote:
>>>>> On Tue, Jan 5, 2010 at 5:27 PM, Jiri Palecek<jpalecek@web.de>  wrote:
>>>>>> Michal Simek napsal(a):
>>>>>>> Hi,
>>>>>> Hi,
>>>>>>> I have some problems with lchown02 test which is caused with this
>>>>>>> patch.
>>>>>>> What is prep_create_link?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Michal
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=ee1a022fc76076d7fc1b6b1797c195244414c038
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> diff --git a/runtest/syscalls b/runtest/syscalls
>>>>>>> index fbe8641..34631ed 100644 (file)
>>>>>>> --- a/runtest/syscalls
>>>>>>> +++ b/runtest/syscalls
>>>>>>> @@ -462,10 +462,10 @@ kill12 kill12
>>>>>>>
>>>>>>> lchown01 lchown01
>>>>>>> lchown01_16 lchown01_16
>>>>>>> -lchown02 cp -p $LTPROOT/testcases/bin/create_link $TMP; lchown02
>>>>>>> -lchown02_16 cp -p $LTPROOT/testcases/bin/create_link $TMP;  
>>>>>>> lchown02_16
>>>>>>> +lchown02 prep_create_link; lchown02
>>>>>>> +lchown02_16 prep_create_link; lchown02_16
>>>>>> IMHO it should do the same as the line above. But I think the whole
>>>>>> thing
>>>>>> could be deleted without causing any grief:
>>>>>>
>>>>>>
>>>>>> http://repo.or.cz/w/ltp-debian.git?a=commit;h=a5499edcf368fa88df924f94ffcbe63c22b46e82
>>>>> The test needs create_link in $TMP; that's why I scripted it as a
>>>>> one-liner (but stupid me probably forgot to add the script to CVS
>>>>> -_-).
>>>>> Let me look and I'll get back to you shortly.
>>>> Fixed. The executable needed CAP_CHOWN capability and that's part of
>>>> the point behind that script...
>>> Couldn't the executable just get CAP_CHOWN with cap_set_proc in case  
>>> it is
>>> running under root with restricted capabilities?
>>>
>>> I'm not sure it wouldn't fail even with the suid-root executable under  
>>> such
>>> condition - are you really sure it doesn't (esp. in the face of  
>>> lchown01,
>>> which would fail almost surely and doesn't have this hack)?
>>      This requires libcap though, which means that any system under
>> test without it would fail the test:
>>  NAME
>>        cap_get_proc,  cap_set_proc,  capgetp - capability manipulation  
>> on pro-
>>        cesses
>>  SYNOPSIS
>>        #include <sys/capability.h>
>>         cap_t cap_get_proc(void);
>>         int cap_set_proc(cap_t cap_p);
>>         #include <sys/types.h>
>>         cap_t cap_get_pid(pid_t pid);
>>         Link with -lcap.
>>      I agree though, this is the best / cleanest solution...
>
>
> Please keep in your mind that not everybody has capability.h in  
> toolchain. For example we don't have it. I can imagine that this could

True, but do you have a capability restricted root and NOT have  
capability.h.

> be one option. You can check if is capability.h and then use it. But if  
> is not there still should be able to run that tests.

Yet I'm still unconviced about the motivation behind this. I tried running  
the *chown* tests under root with CAP_CHOWN dropped. As you can see in the  
attachment, all the tests failed (except for chown01, which is because  
this test doesn't actually test the functionality of chown). But, only  
lchown02 has this prep_create_link hack (and I'm actually unsure it would  
help in this case). So I don't know if these tests are actually meant to  
be working under these conditions, and if not, I can't see the reason of  
this prep_create_link script.

Regards
    Jiri Palecek

[-- Attachment #2: output --]
[-- Type: application/octet-stream, Size: 12170 bytes --]

<<<test_start>>>
tag=chown01 stime=1262958701
cmdline="chown01"
contacts=""
analysis=exit
<<<test_output>>>
chown01     1  TPASS  :  chown(t_10233, 0,0) returned 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown02 stime=1262958701
cmdline="chown02"
contacts=""
analysis=exit
<<<test_output>>>
chown02     1  TFAIL  :  chown() Fails on testfile1, errno=1
chown02     2  TFAIL  :  chown() Fails on testfile2, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown03 stime=1262958701
cmdline="chown03"
contacts=""
analysis=exit
<<<test_output>>>
chown03     1  TBROK  :  fchown(testfile) failed: errno=EPERM(1): Operation not permitted
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=chown04 stime=1262958701
cmdline="chown04"
contacts=""
analysis=exit
<<<test_output>>>
chown04     1  TBROK  :  Fail to modify tfile_1 ownership(s)!: errno=EPERM(1): Operation not permitted
chown04     2  TBROK  :  Remaining cases broken
chown04     3  TBROK  :  Remaining cases broken
chown04     4  TBROK  :  Remaining cases broken
chown04     5  TBROK  :  Remaining cases broken
chown04     6  TBROK  :  Remaining cases broken
chown04     7  TBROK  :  Remaining cases broken
chown04     8  TBROK  :  chmod(testdir_1) failed: errno=ENOENT(2): No such file or directory
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown05 stime=1262958701
cmdline="chown05"
contacts=""
analysis=exit
<<<test_output>>>
chown05     1  TFAIL  :  chown() Fails to Change Owner/Group ids, errno=1
chown05     2  TFAIL  :  chown() Fails to Change Owner id only, errno=1
chown05     3  TFAIL  :  chown() Fails to Change Owner id only, errno=1
chown05     4  TFAIL  :  chown() Fails to Change Group id only, errno=1
chown05     5  TFAIL  :  chown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown01 stime=1262958701
cmdline="fchown01"
contacts=""
analysis=exit
<<<test_output>>>
fchown01    1  TPASS  :  fchown(Fd, geteuid(), getegid()) returned 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown02 stime=1262958701
cmdline="fchown02"
contacts=""
analysis=exit
<<<test_output>>>
fchown02    1  TFAIL  :  fchown() Fails on testfile1, errno=1
fchown02    2  TFAIL  :  fchown() Fails on testfile2, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown03 stime=1262958701
cmdline="fchown03"
contacts=""
analysis=exit
<<<test_output>>>
fchown03    1  TBROK  :  Fail to modify Ownership of testfile: Operation not permitted
<<<execution_status>>>
initiation_status="ok"
duration=1 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=fchown04 stime=1262958702
cmdline="fchown04"
contacts=""
analysis=exit
<<<test_output>>>
fchown04    1  TBROK  :  Fail to modify tfile_1 ownership(s)! Operation not permitted
fchown04    2  TBROK  :  Remaining cases broken
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown05 stime=1262958702
cmdline="fchown05"
contacts=""
analysis=exit
<<<test_output>>>
fchown05    1  TFAIL  :  fchown() Fails to Change Owner/Group ids, errno=1
fchown05    2  TFAIL  :  fchown() Fails to Change Owner id only, errno=1
fchown05    3  TFAIL  :  fchown() Fails to Change Owner id only, errno=1
fchown05    4  TFAIL  :  fchown() Fails to Change Group id only, errno=1
fchown05    5  TFAIL  :  fchown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=lchown01 stime=1262958702
cmdline="lchown01"
contacts=""
analysis=exit
<<<test_output>>>
lchown01    1  TFAIL  :  lchown() Fails to Change Owner/Group ids, errno=1
lchown01    2  TFAIL  :  lchown() Fails to Change Owner id only, errno=1
lchown01    3  TFAIL  :  lchown() Fails to Change Owner id only, errno=1
lchown01    4  TFAIL  :  lchown() Fails to Change Group id only, errno=1
lchown01    5  TFAIL  :  lchown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=lchown02 stime=1262958702
cmdline="lchown02"
contacts=""
analysis=exit
<<<test_output>>>
lchown02    1  TBROK  :  chown() of tfile_1 failed, error 1: Operation not permitted

lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown01_16 stime=1262958702
cmdline="chown01_16"
contacts=""
analysis=exit
<<<test_output>>>
chown01     1  TPASS  :  chown(t_10245, 0,0) returned 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown02_16 stime=1262958702
cmdline="chown02_16"
contacts=""
analysis=exit
<<<test_output>>>
chown02     1  TFAIL  :  chown() Fails on testfile1, errno=1
chown02     2  TFAIL  :  chown() Fails on testfile2, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown03_16 stime=1262958702
cmdline="chown03_16"
contacts=""
analysis=exit
<<<test_output>>>
chown03     1  TBROK  :  fchown(testfile) failed: errno=EPERM(1): Operation not permitted
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=chown04_16 stime=1262958702
cmdline="chown04_16"
contacts=""
analysis=exit
<<<test_output>>>
chown04     1  TBROK  :  Fail to modify tfile_1 ownership(s)!: errno=EPERM(1): Operation not permitted
chown04     2  TBROK  :  Remaining cases broken
chown04     3  TBROK  :  Remaining cases broken
chown04     4  TBROK  :  Remaining cases broken
chown04     5  TBROK  :  Remaining cases broken
chown04     6  TBROK  :  Remaining cases broken
chown04     7  TBROK  :  Remaining cases broken
chown04     8  TBROK  :  chmod(testdir_1) failed: errno=ENOENT(2): No such file or directory
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=chown05_16 stime=1262958702
cmdline="chown05_16"
contacts=""
analysis=exit
<<<test_output>>>
chown05     1  TFAIL  :  chown() Fails to Change Owner/Group ids, errno=1
chown05     2  TFAIL  :  chown() Fails to Change Owner id only, errno=1
chown05     3  TFAIL  :  chown() Fails to Change Owner id only, errno=1
chown05     4  TFAIL  :  chown() Fails to Change Group id only, errno=1
chown05     5  TFAIL  :  chown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown01_16 stime=1262958702
cmdline="fchown01_16"
contacts=""
analysis=exit
<<<test_output>>>
fchown01    1  TPASS  :  fchown(Fd, geteuid(), getegid()) returned 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=1 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown02_16 stime=1262958702
cmdline="fchown02_16"
contacts=""
analysis=exit
<<<test_output>>>
fchown02    1  TFAIL  :  fchown() Fails on testfile1, errno=1
fchown02    2  TFAIL  :  fchown() Fails on testfile2, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=fchown03_16 stime=1262958702
cmdline="fchown03_16"
contacts=""
analysis=exit
<<<test_output>>>
fchown03    1  TBROK  :  Fail to modify Ownership of testfile: Operation not permitted
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchown04_16 stime=1262958702
cmdline="fchown04_16"
contacts=""
analysis=exit
<<<test_output>>>
fchown04    1  TBROK  :  Fail to modify tfile_1 ownership(s)! Operation not permitted
fchown04    2  TBROK  :  Remaining cases broken
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=1
<<<test_end>>>
<<<test_start>>>
tag=fchown05_16 stime=1262958702
cmdline="fchown05_16"
contacts=""
analysis=exit
<<<test_output>>>
fchown05    1  TFAIL  :  fchown() Fails to Change Owner/Group ids, errno=1
fchown05    2  TFAIL  :  fchown() Fails to Change Owner id only, errno=1
fchown05    3  TFAIL  :  fchown() Fails to Change Owner id only, errno=1
fchown05    4  TFAIL  :  fchown() Fails to Change Group id only, errno=1
fchown05    5  TFAIL  :  fchown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=fchownat01 stime=1262958702
cmdline="fchownat01"
contacts=""
analysis=exit
<<<test_output>>>
fchownat01    1  TPASS  :  fchownat() returned the expected  errno 0: Success
fchownat01    2  TPASS  :  fchownat() returned the expected  errno 0: Success
fchownat01    3  TPASS  :  fchownat() returned the expected  errno 20: Not a directory
fchownat01    4  TPASS  :  fchownat() returned the expected  errno 9: Bad file descriptor
fchownat01    5  TPASS  :  fchownat() returned the expected  errno 22: Invalid argument
fchownat01    6  TPASS  :  fchownat() returned the expected  errno 0: Success
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=lchown01_16 stime=1262958702
cmdline="lchown01_16"
contacts=""
analysis=exit
<<<test_output>>>
lchown01    1  TFAIL  :  lchown() Fails to Change Owner/Group ids, errno=1
lchown01    2  TFAIL  :  lchown() Fails to Change Owner id only, errno=1
lchown01    3  TFAIL  :  lchown() Fails to Change Owner id only, errno=1
lchown01    4  TFAIL  :  lchown() Fails to Change Group id only, errno=1
lchown01    5  TFAIL  :  lchown() Fails to Change Group id only, errno=1
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=1 corefile=no
cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=lchown02_16 stime=1262958702
cmdline="lchown02_16"
contacts=""
analysis=exit
<<<test_output>>>
lchown02    1  TBROK  :  chown() of tfile_1 failed, error 1: Operation not permitted

lchown02    2  TBROK  :  Remaining cases broken
lchown02    3  TBROK  :  Remaining cases broken
lchown02    4  TBROK  :  Remaining cases broken
lchown02    5  TBROK  :  Remaining cases broken
lchown02    6  TBROK  :  Remaining cases broken
lchown02    7  TBROK  :  Remaining cases broken
incrementing stop
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=1
<<<test_end>>>

[-- Attachment #3: Type: text/plain, Size: 390 bytes --]

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2010-01-08 15:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 15:10 [LTP] lchown test case Michal Simek
2010-01-06  1:27 ` Jiri Palecek
2010-01-06  1:41   ` Garrett Cooper
2010-01-06  2:31     ` Garrett Cooper
2010-01-06 12:13       ` Michal Simek
2010-01-06 19:24         ` Garrett Cooper
2010-01-07  1:33       ` Jiri Palecek
2010-01-07  5:57         ` Garrett Cooper
2010-01-07 14:02           ` Michal Simek
2010-01-08 15:40             ` Jiří Paleček

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox