Re: [LTP] [PATCH] Add case about arch_prctl syscall.

[路斐 <lufei@uniontech.com>]

Hi, Cyril. 
Thanks again very much.


As written in man page, ENODEV seems only for ARCH_SET_CPUID, so I didn't use TST_EXP_FAIL in ARCH_GET_CPUID check. ARCH_GET_CPUID always success with returning cpuid status, I've tested this on a Intel J1900 machine witch has no cpuid_fault flag. I've resent the patch.

Lu Fei
site：www.uniontech.com
tel：(+86)18501012352
addr: Xi'an, China 



 
 
------------------ Original ------------------
From: &nbsp;"Cyril&nbsp;Hrubis"<chrubis@suse.cz&gt;;
Date: &nbsp;Tue, May 7, 2024 12:51 PM
To: &nbsp;"lufei"<lufei@uniontech.com&gt;; 
Cc: &nbsp;"ltp"<ltp@lists.linux.it&gt;; "jstancek"<jstancek@redhat.com&gt;; 
Subject: &nbsp;Re: [PATCH] Add case about arch_prctl syscall.

&nbsp;

Hi!
&gt; +static void run(unsigned int index)
&gt; +{
&gt; +	struct tcase tc = tcases[index];
&gt; +
&gt; +	TEST(arch_prctl_set(ARCH_SET_CPUID, tc.input));
&gt; +
&gt; +	if (TST_RET == tc.set_exp)
&gt; +		if (tc.set_exp == -1)
&gt; +			tst_res((TST_ERR == tc.tst_errno ? TPASS : TFAIL),
&gt; +				"set cpuid, expect: %s, get: %s",
&gt; +				tst_strerrno(tc.tst_errno),
&gt; +				tst_strerrno(TST_ERR));
&gt; +		else
&gt; +			tst_res(TPASS, "set cpuid succeed.");
&gt; +	else
&gt; +		tst_res(TFAIL, "set cpuid failed.");

This is kind of ugly, why can't we just do:

	if (tag)
		TST_EXP_PASS(arch_prctl_set(ARCH_SET_CPUID, index));
	else
		TST_EXP_FAIL(arch_prctl_set(ARCH_SET_CPUID, index), ENODEV);

&gt; +	TEST(arch_prctl_get(ARCH_GET_CPUID));
&gt; +
&gt; +	if (TST_RET == tc.get_exp)
&gt; +		tst_res(TPASS, "get cpuid succeed.");
&gt; +	else
&gt; +		tst_res(TFAIL, "get cpuid failed.");


We have to check the errno here as well, just branch on the tag as well:

	if (tag) {
		TEST(arch_prctl_get(ARCH_GET_CPUID));

		if (TST_RET == index)
			tst_res(TPASS, "...");
		else
			tst_res(FAIL, "...");
	} else {
		TST_EXP_FAIL(arch_prctl_get(ARCH_GET_CPUID), ENODEV);
	}

Generally the use of TST_EXP_FAIL() is prefered whenever possible.

&gt; +}
&gt; +
&gt; +static struct tst_test test = {
&gt; +	.test = run,
&gt; +	.setup = setup,
&gt; +	.tcnt = ARRAY_SIZE(tcases),
&gt; +	.min_kver = "4.12",
&gt; +	.supported_archs = (const char *const []){"x86_64", "x86", NULL}
&gt; +};
&gt; +
&gt; +#else /* HAVE_ASM_PRCTL_H */
&gt; +TST_TEST_TCONF("missing <asm/prctl.h&gt;");
&gt; +#endif
&gt; -- 
&gt; 2.39.3
&gt; 

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp