From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: Norbert Lange <nolange79@gmail.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH 2/2] lttng_ust_init_thread: call urcu_register_thread
Date: Tue, 19 Jul 2022 15:40:22 -0400 (EDT) [thread overview]
Message-ID: <1308824469.74177.1658259622444.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20220718215955.124991-2-nolange79@gmail.com>
----- On Jul 18, 2022, at 5:59 PM, Norbert Lange via lttng-dev lttng-dev@lists.lttng.org wrote:
> Eagerly register the thread, and avoid taking mutex during the
> first tracepoint.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Please resubmit with the next round with my acked-by tag.
Mathieu
>
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
> ---
> src/lib/lttng-ust/lttng-ust-comm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/lib/lttng-ust/lttng-ust-comm.c
> b/src/lib/lttng-ust/lttng-ust-comm.c
> index ba0bd985..3ff6b086 100644
> --- a/src/lib/lttng-ust/lttng-ust-comm.c
> +++ b/src/lib/lttng-ust/lttng-ust-comm.c
> @@ -447,6 +447,8 @@ void lttng_ust_init_thread(void)
> * this thread attempts to use them.
> */
> lttng_ust_alloc_tls(true);
> +
> + lttng_ust_urcu_register_thread();
> }
>
> int lttng_get_notify_socket(void *owner)
> --
> 2.35.1
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2022-07-19 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 21:59 [lttng-dev] [PATCH 1/2] lttng_ust_init_thread: initialise cached context values Norbert Lange via lttng-dev
2022-07-18 21:59 ` [lttng-dev] [PATCH 2/2] lttng_ust_init_thread: call urcu_register_thread Norbert Lange via lttng-dev
2022-07-19 19:40 ` Mathieu Desnoyers via lttng-dev [this message]
2022-07-19 19:39 ` [lttng-dev] [PATCH 1/2] lttng_ust_init_thread: initialise cached context values Mathieu Desnoyers via lttng-dev
2022-07-20 20:00 ` Norbert Lange via lttng-dev
2022-07-20 20:48 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308824469.74177.1658259622444.JavaMail.zimbra@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=nolange79@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).