From: Vincent Whitchurch via lttng-dev <lttng-dev@lists.lttng.org>
To: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>, kernel <kernel@axis.com>
Subject: Re: [lttng-dev] [PATCH lttng-tools] Fix: consumer-stream: use-after-free of metadata bucket
Date: Tue, 8 Mar 2022 09:10:35 +0100 [thread overview]
Message-ID: <20220308081035.GA12065@axis.com> (raw)
In-Reply-To: <921962800.125936.1646674669086.JavaMail.zimbra@efficios.com>
On Mon, Mar 07, 2022 at 06:37:49PM +0100, Jérémie Galarneau wrote:
> I had a chance to look into this and came up with the following fix:
> https://review.lttng.org/c/lttng-tools/+/7478/4
>
> Would you have a chance to try it on your end before I merge it?
I've tested the patch stack in patch set #5 and it does fix the problem
for me too. Please feel free to add this if you like:
Tested-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
(By the way, I noticed that patch(1) gets confused by the reproduction
patch which is part of the commit message. This probably shouldn't
matter much though, I only noticed it when I tried to revert the patch
with git show | patch -p1 -R.)
> Thanks for the great bug report!
Thank you for the fix!
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
prev parent reply other threads:[~2022-03-08 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 15:12 [lttng-dev] [PATCH lttng-tools] Fix: consumer-stream: use-after-free of metadata bucket Vincent Whitchurch via lttng-dev
2022-03-01 17:19 ` Jérémie Galarneau via lttng-dev
2022-03-02 9:27 ` Vincent Whitchurch via lttng-dev
2022-03-07 17:37 ` Jérémie Galarneau via lttng-dev
2022-03-08 8:10 ` Vincent Whitchurch via lttng-dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308081035.GA12065@axis.com \
--to=lttng-dev@lists.lttng.org \
--cc=jeremie.galarneau@efficios.com \
--cc=kernel@axis.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).