lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Ashfield via lttng-dev <lttng-dev@lists.lttng.org>
To: lttng-dev@lists.lttng.org
Subject: [lttng-dev] [PATCH 3/3] vmscan: drop isolate_mode (v6.7+)
Date: Thu, 23 Nov 2023 14:32:49 -0500	[thread overview]
Message-ID: <20231123193249.3190764-3-bruce.ashfield@gmail.com> (raw)
In-Reply-To: <20231123193249.3190764-1-bruce.ashfield@gmail.com>

From: Bruce Ashfield <bruce.ashfield@gmail.com>

commit 3dfbb555c98ac55b9 [mm, vmscan: remove ISOLATE_UNMAPPED]
makes the isolate_mode parameter unused, so it is removed.

This updates the event to match.

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
---

Repeating the comment from patch 1 & 2 of this series:

Someone else may or may not already have this in flight,
but I didn't see anything on the list or in the git
repo.

I ran into this failure when working on the v6.7-rc
kernel as part of yocto project kernel updates.

Tweak as necessary, as I'm no expert in the right way
to version these sort of changes.

Bruce

 include/instrumentation/events/mm_vmscan.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/include/instrumentation/events/mm_vmscan.h b/include/instrumentation/events/mm_vmscan.h
index e7e9b613..a3e9ddf2 100644
--- a/include/instrumentation/events/mm_vmscan.h
+++ b/include/instrumentation/events/mm_vmscan.h
@@ -343,12 +343,18 @@ LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
 		unsigned long nr_scanned,
 		unsigned long nr_skipped,
 		unsigned long nr_taken,
+#if (LTTNG_LINUX_VERSION_CODE < LTTNG_KERNEL_VERSION(6,7,0))
 		isolate_mode_t isolate_mode,
+#endif
 		int lru
 	),
 
 	TP_ARGS(classzone_idx, order, nr_requested, nr_scanned, nr_skipped,
-		nr_taken, isolate_mode, lru
+		nr_taken,
+#if (LTTNG_LINUX_VERSION_CODE < LTTNG_KERNEL_VERSION(6,7,0))
+		isolate_mode,
+#endif
+		lru
 	),
 
 	TP_FIELDS(
@@ -358,7 +364,9 @@ LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
 		ctf_integer(unsigned long, nr_scanned, nr_scanned)
 		ctf_integer(unsigned long, nr_skipped, nr_skipped)
 		ctf_integer(unsigned long, nr_taken, nr_taken)
+#if (LTTNG_LINUX_VERSION_CODE < LTTNG_KERNEL_VERSION(6,7,0))
 		ctf_integer(isolate_mode_t, isolate_mode, isolate_mode)
+#endif
 		ctf_integer(int, lru, lru)
 	)
 )
-- 
2.34.1

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

  parent reply	other threads:[~2023-11-23 19:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 19:32 [lttng-dev] [PATCH 1/3] statedump: adjust to v6.7 cpu topology struct Bruce Ashfield via lttng-dev
2023-11-23 19:32 ` [lttng-dev] [PATCH 2/3] wrapper/fdtable: adjust fd lookup to v6.7+ Bruce Ashfield via lttng-dev
2023-11-23 19:32 ` Bruce Ashfield via lttng-dev [this message]
2023-11-23 19:49   ` [lttng-dev] [PATCH 3/3] vmscan: drop isolate_mode (v6.7+) Kienan Stewart via lttng-dev
2023-11-23 19:56     ` Bruce Ashfield via lttng-dev
2023-11-23 20:24       ` Kienan Stewart via lttng-dev
2023-11-28 19:55       ` Kienan Stewart via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123193249.3190764-3-bruce.ashfield@gmail.com \
    --to=lttng-dev@lists.lttng.org \
    --cc=bruce.ashfield@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).