lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Corey Minyard <tcminyard@gmail.com>
To: lttng-dev@lists.lttng.org
Subject: put_ulong calls in lib_ring_buffer_compat_ioctl() should be compat?
Date: Tue, 11 Dec 2012 16:17:52 -0600	[thread overview]
Message-ID: <50C7B110.3040009__5447.09918690405$1355264648$gmane$org@acm.org> (raw)

I was noticing the that some of the put_ulong calls in 
lib_ring_buffer_compat_ioctl() were not compat_put_ulong.  I can't 
imagine this is correct.  Here's a patch to fix it, assuming that is 
wrong.  It seems to work ok.

diff --git a/lib/ringbuffer/ring_buffer_vfs.c 
b/lib/ringbuffer/ring_buffer_vfs.c
index c69b64e..899af81 100644
--- a/lib/ringbuffer/ring_buffer_vfs.c
+++ b/lib/ringbuffer/ring_buffer_vfs.c
@@ -331,7 +331,7 @@ long lib_ring_buffer_compat_ioctl(struct file *filp, 
unsigned int cmd,
          data_size = lib_ring_buffer_get_read_data_size(config, buf);
          if (data_size > UINT_MAX)
              return -EFBIG;
-        return put_ulong(data_size, arg);
+        return compat_put_ulong(data_size, arg);
      }
      case RING_BUFFER_COMPAT_GET_PADDED_SUBBUF_SIZE:
      {
@@ -341,12 +341,12 @@ long lib_ring_buffer_compat_ioctl(struct file 
*filp, unsigned int cmd,
          size = PAGE_ALIGN(size);
          if (size > UINT_MAX)
              return -EFBIG;
-        return put_ulong(size, arg);
+        return compat_put_ulong(size, arg);
      }
      case RING_BUFFER_COMPAT_GET_MAX_SUBBUF_SIZE:
          if (chan->backend.subbuf_size > UINT_MAX)
              return -EFBIG;
-        return put_ulong(chan->backend.subbuf_size, arg);
+        return compat_put_ulong(chan->backend.subbuf_size, arg);
      case RING_BUFFER_COMPAT_GET_MMAP_LEN:
      {
          unsigned long mmap_buf_len;
@@ -358,7 +358,7 @@ long lib_ring_buffer_compat_ioctl(struct file *filp, 
unsigned int cmd,
              mmap_buf_len += chan->backend.subbuf_size;
          if (mmap_buf_len > UINT_MAX)
              return -EFBIG;
-        return put_ulong(mmap_buf_len, arg);
+        return compat_put_ulong(mmap_buf_len, arg);
      }
      case RING_BUFFER_COMPAT_GET_MMAP_READ_OFFSET:
      {
@@ -371,7 +371,7 @@ long lib_ring_buffer_compat_ioctl(struct file *filp, 
unsigned int cmd,
          read_offset = buf->backend.array[sb_bindex]->mmap_offset;
          if (read_offset > UINT_MAX)
              return -EINVAL;
-        return put_ulong(read_offset, arg);
+        return compat_put_ulong(read_offset, arg);
      }
      case RING_BUFFER_COMPAT_FLUSH:
          lib_ring_buffer_switch_slow(buf, SWITCH_ACTIVE);

             reply	other threads:[~2012-12-11 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 22:17 Corey Minyard [this message]
     [not found] <50C7B110.3040009@acm.org>
2012-12-12  2:47 ` put_ulong calls in lib_ring_buffer_compat_ioctl() should be compat? Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='50C7B110.3040009__5447.09918690405$1355264648$gmane$org@acm.org' \
    --to=tcminyard@gmail.com \
    --cc=lttng-dev@lists.lttng.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).