lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: lttng-dev <lttng-dev@lists.lttng.org>
Cc: gdb@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Request change name of function lookup_enum in libbabeltrace to make GDB use this lib
Date: Wed, 5 Dec 2012 19:37:18 +0800	[thread overview]
Message-ID: <CANFwon2s-eJoCrhzJmxhoGx9G2NeOAFf-FDFk1SoxD1OhPxWsg@mail.gmail.com> (raw)

Hi,

I am working on add CTF support to GDB.  You can see my patch review threads in:
http://sourceware.org/ml/gdb-patches/2012-11/msg00552.html
http://sourceware.org/ml/gdb-patches/2012-11/msg00554.html
http://sourceware.org/ml/gdb-patches/2012-11/msg00553.html
http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html
http://sourceware.org/ml/gdb-patches/2012-11/msg00556.html

To make GDB support CTF read, I use libbabeltrace with GDB.  You can
see the patch in
http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html.
I have a issue is  libbabeltrace have a function called lookup_enum
that is same with a GDB function.
I change the function name of GDB to handle this issue in my patch.

But Tom said let libbabeltrace to change function name is better.
So I send this mail to ask do you mind change the function name of
lookup_enum?   If you can change the function name that will be really
helpful for us.  Thanks a lot.
And I post a patch about change the function name in libbabeltrace.

Thanks,
Hui

--- a/formats/ctf/ctf.c
+++ b/formats/ctf/ctf.c
@@ -423,7 +423,7 @@ int ctf_read_event(struct stream_pos *pp
 		} else {
 			struct definition_enum *enum_definition;

-			enum_definition = lookup_enum(&stream->stream_event_header->p, "id", FALSE);
+			enum_definition = ctf_lookup_enum(&stream->stream_event_header->p,
"id", FALSE);
 			if (enum_definition) {
 				id = enum_definition->integer->value._unsigned;
 			}
--- a/include/babeltrace/types.h
+++ b/include/babeltrace/types.h
@@ -513,7 +513,7 @@ struct definition *lookup_definition(con
 struct definition_integer *lookup_integer(const struct definition *definition,
 					  const char *field_name,
 					  int signedness);
-struct definition_enum *lookup_enum(const struct definition *definition,
+struct definition_enum *ctf_lookup_enum(const struct definition *definition,
 				    const char *field_name,
 				    int signedness);
 struct definition *lookup_variant(const struct definition *definition,
--- a/types/types.c
+++ b/types/types.c
@@ -634,7 +634,7 @@ struct definition_integer *lookup_intege
 	return lookup_integer;
 }

-struct definition_enum *lookup_enum(const struct definition *definition,
+struct definition_enum *ctf_lookup_enum(const struct definition *definition,
 				    const char *field_name,
 				    int signedness)
 {

             reply	other threads:[~2012-12-05 11:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 11:37 Hui Zhu [this message]
2012-12-05 12:08 ` [lttng-dev] Request change name of function lookup_enum in libbabeltrace to make GDB use this lib Mathieu Desnoyers
2012-12-05 12:21   ` Hui Zhu
2012-12-06 15:57   ` Pedro Alves
2012-12-06 16:20     ` Pedro Alves
2012-12-06 16:24       ` Mathieu Desnoyers
2012-12-06 16:24       ` Mathieu Desnoyers
2012-12-10  8:30     ` [lttng-dev] " Hui Zhu
2012-12-10 14:05       ` Mathieu Desnoyers
2012-12-11 15:18         ` Hui Zhu
2012-12-20 13:46           ` Hui Zhu
2012-12-20 14:16             ` Mathieu Desnoyers
2012-12-20 14:16             ` [lttng-dev] " Mathieu Desnoyers
     [not found]             ` <20121220141643.GA22763@Krystal>
2012-12-21  2:57               ` Hui Zhu
2013-01-07 21:18                 ` Mathieu Desnoyers
2013-01-09 19:48                   ` [BABELTRACE PATCH] Namespace the lookup_enum function Julien Desfossez
2013-01-13 17:57                     ` Mathieu Desnoyers
2013-01-13 17:57                     ` Mathieu Desnoyers
     [not found]                     ` <20130113175754.GA3917@Krystal>
2013-01-24 17:43                       ` [lttng-dev] " Julien Desfossez
2013-01-25 11:16                         ` Hui Zhu
2013-01-25 11:16                         ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon2s-eJoCrhzJmxhoGx9G2NeOAFf-FDFk1SoxD1OhPxWsg@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb@sourceware.org \
    --cc=lttng-dev@lists.lttng.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).