[PATCH lttng-tools v3 0/4] Dynamic probe list support

[PATCH lttng-tools v3 0/4] Dynamic probe list support

[Jan Glauber]

Hi David,

here are the rebased patches (onto 88564da). There are no functional
changes to the previous version.

Jan Glauber (4):
  Use common functions for module loading and unloading
  Seperate probe modules from control modules
  Remove required parameter from module parameters
  Configurable kernel module probes support

 doc/man/lttng-sessiond.8              |    7 +
 src/bin/lttng-sessiond/kern-modules.h |    3 +-
 src/bin/lttng-sessiond/main.c         |    5 +
 src/bin/lttng-sessiond/modprobe.c     |  307 ++++++++++++++++++---------------
 src/bin/lttng-sessiond/modprobe.h     |    2 +
 src/common/defaults.h                 |    3 +
 src/common/utils.c                    |   10 ++
 src/common/utils.h                    |    1 +
 8 files changed, 200 insertions(+), 138 deletions(-)

-- 
1.7.9.5

Re: [PATCH lttng-tools v3 0/4] Dynamic probe list support

[David Goulet]

[-- Attachment #1.1: Type: text/plain, Size: 1418 bytes --]

Merged!

I merged it with some minor syntax fixes mostly in modprobe.c. There is
one thing I don't accept at all is if/else without {}. Remember the goto
fail; bug :).

Anyhow, I fixed them to fit my OCD if/else issue. ;)

Big thanks for that, this is really great! I would love to improve that
with support in the "lttng" command line that could take a list and
spawn the sessiond with it. Also, the configuration file coming in 2.5
(currently in master).

Cheers!
David

On 14 May (16:26:28), Jan Glauber wrote:
> Hi David,
> 
> here are the rebased patches (onto 88564da). There are no functional
> changes to the previous version.
> 
> Jan Glauber (4):
>   Use common functions for module loading and unloading
>   Seperate probe modules from control modules
>   Remove required parameter from module parameters
>   Configurable kernel module probes support
> 
>  doc/man/lttng-sessiond.8              |    7 +
>  src/bin/lttng-sessiond/kern-modules.h |    3 +-
>  src/bin/lttng-sessiond/main.c         |    5 +
>  src/bin/lttng-sessiond/modprobe.c     |  307 ++++++++++++++++++---------------
>  src/bin/lttng-sessiond/modprobe.h     |    2 +
>  src/common/defaults.h                 |    3 +
>  src/common/utils.c                    |   10 ++
>  src/common/utils.h                    |    1 +
>  8 files changed, 200 insertions(+), 138 deletions(-)
> 
> -- 
> 1.7.9.5
> 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [PATCH lttng-tools v3 0/4] Dynamic probe list support

[Jan Glauber]

[-- Attachment #1.1: Type: text/plain, Size: 2035 bytes --]

Thanks David! I've had the impression that LTTng follows kernel coding
style but it diverts on the if/else case.
Personaly I don't buy the {} is better argument, but I'll try to remember
your preference :)

If you could help me a bit with the config file syntax I'll be happy to add
support for it.
What would help me is a working example with all the required values. As I
said
an empty config file did not work for me, so there seems to be some
required options and I was not able to
figure them out.

Cheers,
Jan


2014-05-14 22:47 GMT+02:00 David Goulet <dgoulet@efficios.com>:

> Merged!
>
> I merged it with some minor syntax fixes mostly in modprobe.c. There is
> one thing I don't accept at all is if/else without {}. Remember the goto
> fail; bug :).
>
> Anyhow, I fixed them to fit my OCD if/else issue. ;)
>
> Big thanks for that, this is really great! I would love to improve that
> with support in the "lttng" command line that could take a list and
> spawn the sessiond with it. Also, the configuration file coming in 2.5
> (currently in master).
>
> Cheers!
> David
>
> On 14 May (16:26:28), Jan Glauber wrote:
> > Hi David,
> >
> > here are the rebased patches (onto 88564da). There are no functional
> > changes to the previous version.
> >
> > Jan Glauber (4):
> >   Use common functions for module loading and unloading
> >   Seperate probe modules from control modules
> >   Remove required parameter from module parameters
> >   Configurable kernel module probes support
> >
> >  doc/man/lttng-sessiond.8              |    7 +
> >  src/bin/lttng-sessiond/kern-modules.h |    3 +-
> >  src/bin/lttng-sessiond/main.c         |    5 +
> >  src/bin/lttng-sessiond/modprobe.c     |  307
> ++++++++++++++++++---------------
> >  src/bin/lttng-sessiond/modprobe.h     |    2 +
> >  src/common/defaults.h                 |    3 +
> >  src/common/utils.c                    |   10 ++
> >  src/common/utils.h                    |    1 +
> >  8 files changed, 200 insertions(+), 138 deletions(-)
> >
> > --
> > 1.7.9.5
> >
>

[-- Attachment #1.2: Type: text/html, Size: 2837 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev