lustre-devel-lustre.org archive mirror
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 03/10] lustre: ptlrpc: make ptlrpc_bulk_frag_ops always const.
Date: Sun, 21 Jul 2019 22:12:15 -0400	[thread overview]
Message-ID: <1563761542-3708-4-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1563761542-3708-1-git-send-email-jsimmons@infradead.org>

From: NeilBrown <neilb@suse.com>

There is one place where a non-const pointer to this struct
exists, and that causes a cast to be required.

Make it always const, and discard the cast.

Signed-off-by: NeilBrown <neilb@suse.com>
WC-bug-id: https://jira.whamcloud.com/browse/LU-4423
Reviewed-on: https://review.whamcloud.com/35295
Reviewed-by: Petros Koutoupis <pkoutoupis@cray.com>
Reviewed-by: Shaun Tancheff <stancheff@cray.com>
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
 fs/lustre/include/lustre_net.h | 2 +-
 fs/lustre/ptlrpc/client.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/lustre/include/lustre_net.h b/fs/lustre/include/lustre_net.h
index 1cf0f12..83f8aff 100644
--- a/fs/lustre/include/lustre_net.h
+++ b/fs/lustre/include/lustre_net.h
@@ -1222,7 +1222,7 @@ struct ptlrpc_bulk_desc {
 	struct obd_import		*bd_import;
 	/** Back pointer to the request */
 	struct ptlrpc_request		*bd_req;
-	struct ptlrpc_bulk_frag_ops	*bd_frag_ops;
+	const struct ptlrpc_bulk_frag_ops *bd_frag_ops;
 	wait_queue_head_t		bd_waitq;     /* server side only WQ */
 	int				bd_iov_count; /* # entries in bd_iov */
 	int				bd_max_iov;   /* allocated size of bd_iov */
diff --git a/fs/lustre/ptlrpc/client.c b/fs/lustre/ptlrpc/client.c
index 364c61f..ff1fa68 100644
--- a/fs/lustre/ptlrpc/client.c
+++ b/fs/lustre/ptlrpc/client.c
@@ -150,7 +150,7 @@ struct ptlrpc_bulk_desc *ptlrpc_new_bulk(unsigned int nfrags,
 	desc->bd_portal = portal;
 	desc->bd_type = type;
 	desc->bd_md_count = 0;
-	desc->bd_frag_ops = (struct ptlrpc_bulk_frag_ops *)ops;
+	desc->bd_frag_ops = ops;
 	LASSERT(max_brw > 0);
 	desc->bd_md_max_brw = min(max_brw, PTLRPC_BULK_OPS_COUNT);
 	/*
-- 
1.8.3.1

  parent reply	other threads:[~2019-07-22  2:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22  2:12 [lustre-devel] [PATCH 00/10] lustre: push patches ready from lustre-testing James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 01/10] lustre: ldlm: discard varname in ldlm_pool James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 02/10] lustre: lprocfs: use log2.h macros instead of shift loop James Simmons
2019-07-22  2:12 ` James Simmons [this message]
2019-07-22  2:12 ` [lustre-devel] [PATCH 04/10] lustre: mgc: remove llog_process_lock James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 05/10] lustre: don't declare extern variables in C files James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 06/10] lnet: socklnd: fix infinite loop in ksocknal_push() James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 07/10] lustre: ptlrpc: remove inline on non-inlined functions James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 08/10] lustre: convert rsi_sem to a spinlock James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 09/10] lustre: ptlrpc: make ptlrpc_last_xid an atomic64_t James Simmons
2019-07-22  2:12 ` [lustre-devel] [PATCH 10/10] lustre: ptlrpc: simplify struct ptlrpc_request_set James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1563761542-3708-4-git-send-email-jsimmons@infradead.org \
    --to=jsimmons@infradead.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).