* [lustre-devel] [PATCH] lustre: lnet: fix needed headers for lnet headers
@ 2019-07-24 20:45 James Simmons
2019-07-25 4:53 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: James Simmons @ 2019-07-24 20:45 UTC (permalink / raw)
To: lustre-devel
The linux kernel now has a sanity check for the global headers and
LNet are missing a few headers to allow them to build properly.
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
include/linux/libcfs/libcfs_fail.h | 1 +
include/linux/libcfs/libcfs_private.h | 3 +++
include/uapi/linux/lnet/lnetst.h | 2 ++
3 files changed, 6 insertions(+)
diff --git a/include/linux/libcfs/libcfs_fail.h b/include/linux/libcfs/libcfs_fail.h
index 0e73eef..f52a82a 100644
--- a/include/linux/libcfs/libcfs_fail.h
+++ b/include/linux/libcfs/libcfs_fail.h
@@ -35,6 +35,7 @@
#include <linux/sched.h>
#include <linux/wait.h>
+#include <linux/libcfs/libcfs_debug.h>
extern unsigned long cfs_fail_loc;
extern unsigned int cfs_fail_val;
diff --git a/include/linux/libcfs/libcfs_private.h b/include/linux/libcfs/libcfs_private.h
index 515fd63..2e8cff6 100644
--- a/include/linux/libcfs/libcfs_private.h
+++ b/include/linux/libcfs/libcfs_private.h
@@ -39,6 +39,9 @@
#ifndef __LIBCFS_PRIVATE_H__
#define __LIBCFS_PRIVATE_H__
+#include <linux/sched.h>
+#include <linux/libcfs/libcfs_debug.h>
+
#ifndef DEBUG_SUBSYSTEM
# define DEBUG_SUBSYSTEM S_UNDEFINED
#endif
diff --git a/include/uapi/linux/lnet/lnetst.h b/include/uapi/linux/lnet/lnetst.h
index 27fcd91..449c5e6 100644
--- a/include/uapi/linux/lnet/lnetst.h
+++ b/include/uapi/linux/lnet/lnetst.h
@@ -38,6 +38,8 @@
#define __LNET_ST_H__
#include <linux/types.h>
+#include <linux/time.h>
+#include <linux/lnet/lnet-types.h>
#define LST_FEAT_NONE (0)
#define LST_FEAT_BULK_LEN (1 << 0) /* enable variable page size */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [lustre-devel] [PATCH] lustre: lnet: fix needed headers for lnet headers
2019-07-24 20:45 [lustre-devel] [PATCH] lustre: lnet: fix needed headers for lnet headers James Simmons
@ 2019-07-25 4:53 ` NeilBrown
2019-07-25 18:46 ` James Simmons
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2019-07-25 4:53 UTC (permalink / raw)
To: lustre-devel
On Wed, Jul 24 2019, James Simmons wrote:
> The linux kernel now has a sanity check for the global headers and
> LNet are missing a few headers to allow them to build properly.
Thanks.
I've modified the above to:
The linux kernel now has a sanity check for the global headers,
activated by CONFIG_HEADER_TEST=y and CONFIG_KERNEL_HEADER_TEST=y.
Some LNet headers are missing a few headers to allow them to build properly.
and applied the patch.
NeilBrown
>
> Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
> include/linux/libcfs/libcfs_fail.h | 1 +
> include/linux/libcfs/libcfs_private.h | 3 +++
> include/uapi/linux/lnet/lnetst.h | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/include/linux/libcfs/libcfs_fail.h b/include/linux/libcfs/libcfs_fail.h
> index 0e73eef..f52a82a 100644
> --- a/include/linux/libcfs/libcfs_fail.h
> +++ b/include/linux/libcfs/libcfs_fail.h
> @@ -35,6 +35,7 @@
>
> #include <linux/sched.h>
> #include <linux/wait.h>
> +#include <linux/libcfs/libcfs_debug.h>
>
> extern unsigned long cfs_fail_loc;
> extern unsigned int cfs_fail_val;
> diff --git a/include/linux/libcfs/libcfs_private.h b/include/linux/libcfs/libcfs_private.h
> index 515fd63..2e8cff6 100644
> --- a/include/linux/libcfs/libcfs_private.h
> +++ b/include/linux/libcfs/libcfs_private.h
> @@ -39,6 +39,9 @@
> #ifndef __LIBCFS_PRIVATE_H__
> #define __LIBCFS_PRIVATE_H__
>
> +#include <linux/sched.h>
> +#include <linux/libcfs/libcfs_debug.h>
> +
> #ifndef DEBUG_SUBSYSTEM
> # define DEBUG_SUBSYSTEM S_UNDEFINED
> #endif
> diff --git a/include/uapi/linux/lnet/lnetst.h b/include/uapi/linux/lnet/lnetst.h
> index 27fcd91..449c5e6 100644
> --- a/include/uapi/linux/lnet/lnetst.h
> +++ b/include/uapi/linux/lnet/lnetst.h
> @@ -38,6 +38,8 @@
> #define __LNET_ST_H__
>
> #include <linux/types.h>
> +#include <linux/time.h>
> +#include <linux/lnet/lnet-types.h>
>
> #define LST_FEAT_NONE (0)
> #define LST_FEAT_BULK_LEN (1 << 0) /* enable variable page size */
> --
> 1.8.3.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20190725/bf0ed17c/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread* [lustre-devel] [PATCH] lustre: lnet: fix needed headers for lnet headers
2019-07-25 4:53 ` NeilBrown
@ 2019-07-25 18:46 ` James Simmons
0 siblings, 0 replies; 3+ messages in thread
From: James Simmons @ 2019-07-25 18:46 UTC (permalink / raw)
To: lustre-devel
> On Wed, Jul 24 2019, James Simmons wrote:
>
> > The linux kernel now has a sanity check for the global headers and
> > LNet are missing a few headers to allow them to build properly.
>
> Thanks.
> I've modified the above to:
>
> The linux kernel now has a sanity check for the global headers,
> activated by CONFIG_HEADER_TEST=y and CONFIG_KERNEL_HEADER_TEST=y.
> Some LNet headers are missing a few headers to allow them to build properly.
>
> and applied the patch.
>
Acked-by: James Simmons <jsimmons@infradead.org>
> > ---
> > include/linux/libcfs/libcfs_fail.h | 1 +
> > include/linux/libcfs/libcfs_private.h | 3 +++
> > include/uapi/linux/lnet/lnetst.h | 2 ++
> > 3 files changed, 6 insertions(+)
> >
> > diff --git a/include/linux/libcfs/libcfs_fail.h b/include/linux/libcfs/libcfs_fail.h
> > index 0e73eef..f52a82a 100644
> > --- a/include/linux/libcfs/libcfs_fail.h
> > +++ b/include/linux/libcfs/libcfs_fail.h
> > @@ -35,6 +35,7 @@
> >
> > #include <linux/sched.h>
> > #include <linux/wait.h>
> > +#include <linux/libcfs/libcfs_debug.h>
> >
> > extern unsigned long cfs_fail_loc;
> > extern unsigned int cfs_fail_val;
> > diff --git a/include/linux/libcfs/libcfs_private.h b/include/linux/libcfs/libcfs_private.h
> > index 515fd63..2e8cff6 100644
> > --- a/include/linux/libcfs/libcfs_private.h
> > +++ b/include/linux/libcfs/libcfs_private.h
> > @@ -39,6 +39,9 @@
> > #ifndef __LIBCFS_PRIVATE_H__
> > #define __LIBCFS_PRIVATE_H__
> >
> > +#include <linux/sched.h>
> > +#include <linux/libcfs/libcfs_debug.h>
> > +
> > #ifndef DEBUG_SUBSYSTEM
> > # define DEBUG_SUBSYSTEM S_UNDEFINED
> > #endif
> > diff --git a/include/uapi/linux/lnet/lnetst.h b/include/uapi/linux/lnet/lnetst.h
> > index 27fcd91..449c5e6 100644
> > --- a/include/uapi/linux/lnet/lnetst.h
> > +++ b/include/uapi/linux/lnet/lnetst.h
> > @@ -38,6 +38,8 @@
> > #define __LNET_ST_H__
> >
> > #include <linux/types.h>
> > +#include <linux/time.h>
> > +#include <linux/lnet/lnet-types.h>
> >
> > #define LST_FEAT_NONE (0)
> > #define LST_FEAT_BULK_LEN (1 << 0) /* enable variable page size */
> > --
> > 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-25 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 20:45 [lustre-devel] [PATCH] lustre: lnet: fix needed headers for lnet headers James Simmons
2019-07-25 4:53 ` NeilBrown
2019-07-25 18:46 ` James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).